How to update mysql_result(mysql_query("SELECT COUNT(*) FROM `table`for php 7.4

[kuau]

I am updating an old site written in php 5.4 to php 7.4 and I am having trouble with this line...

$upcoming = mysql_result(mysql_query("SELECT COUNT(*) FROM `event` WHERE `approved`=1 AND (`startdate` >= '".$today."' OR `oge` > 0) "),0);

I tried this:

if ($result4 = mysqli_query($connection, "SELECT COUNT(*) FROM `event` WHERE `approved`=1 AND (`startdate` >= '".$today."' OR `oge` > 0) "))  { $upcoming = mysqli_num_rows($result4); }

but it gave the count as 1 instead of 422.

Not sure what I am doing wrong. Please can one of you php pros shed some light? Thanks.

[james438]

I guess I would need to see what the data is that you are working with, however I do see one error.

Try changing:

$result4 = mysqli_query

to:

$result4 == mysqli_query

[kuau]

Dear James: Thank you. Yes, that was definitely a mistake but, when I fixed it, then I got no result. The COUNT is for the number of upcoming events on an event calendar. You can see what I am trying to fix under the small calendar in the top center of this page: https://www.*.com/ Probably I don't even need an IF clause. I'm simply trying to count the number of events in a table that are not expired. There must be something wrong with the COUNT phrase. Has that been deprecated in 7.4? Thanks for helping me.

[james438]

Count has not been deprecated, but I noticed after updating my website to PHP 7.4 that some MySQL functions operated somewhat differently.

For now I would get rid of the IF statement until we can figure out the solution and then add it back if you still need it.

What is: SELECT COUNT(*)? Shouldn't it be SELECT * instead?

I would write your query something like this:

$get_list="SELECT * FROM event WHERE approved=1 AND (startdate >= $today OR oge > 0)";
$result4 = mysqli_query($connection, $get_list);
$upcoming = mysqli_num_rows($result4);
echo "number of results found: $upcoming";

[kuau]

Dear James: I just came here to tell you I figured it out by finding an example online here https://www.w3schools.com/Php/func_mysqli_num_rows.asp and then saw your solution which is basically the same as what I changed it to... in the example, they did not use ==, perhaps because it is just checking if there was a valid result...

 $sql = "SELECT * FROM `event` WHERE `approved`=1 AND (`startdate` >= '".$today."' OR `oge` > 0)" ;
   if ($result=mysqli_query($connection,$sql)){ $upcoming = mysqli_num_rows($result); mysqli_free_result($result); } mysqli_close($connection);

The original code was kind of a shortcut way of coding. It makes more sense to me the way you did it. Anyway, thanks very much. It seems the COUNT function may have been replaced with mysqli_num_rows. Anyway, it works perfectly now. Thanks again! aa

[james438]

Just a quick note on IF statements with php.

<?php
$test='0';
if ($test=='1') $test="u";
echo"$test";
?>

The above uses "==" and produces "0".

<?php
$test='0';
if ($test='1') $test="u";
echo"$test";
?>

This second code snippet one "=" and produces "u". This is because by using one = you are setting the value of $test to '1'. I could use anything and it would be true. I could use $test='346' or $test='James' and it would be true.

In the first example, by using two == you create a conditional statement which is either true or false.

[kuau]

Thanks for explaining. So the second case is more like if setting $test to 1 is true, then $test="u"? If the second example is not a conditional statement, why is the 'if' used? It seems kind of pointless if you can just say $test="u".

[kuau]

Thanks, Zinavo, but that code does not use mysqli. I am trying to upgrade to code that will work in 7.4 mysql_query has been deprecated. Sounds as if you may need to update your code too.

[james438]

Thanks for explaining. So the second case is more like if setting $test to 1 is true, then $test="u"? If the second example is not a conditional statement, why is the 'if' used? It seems kind of pointless if you can just say $test="u".

Correct. In the second example where only one = is used if ($test='1') $test="u"; it is a conditional statement, but it is always true. Since it is always true, it is not useful as an if statement.

I wanted to be sure you were aware of that, otherwise it might cause trouble for you later.

[kuau]

Dear James: Thank you so much! You made me realize that my code was actually causing the sql command to run twice. I thought it was checking to see if the command was successful but in fact I was re-executing the command. This resulted in every event being added twice to the database and every new location too. OMG. This had been going on for years and made a huge mess. And it all had to do with that fake conditional with the single =. Now I have to check all my code because I seem to have used that all over the place. Thanks for teaching me what it means.