javascript not to open in new window

**jscheuer1** · 02-26-2018, 11:21 PM

Ah, yes, (my fault this time) not resetting the newContent variable, add red:

Code:

;(function(){
	var div, ft, trg;
	if(document.getElementById('aanumbersresults')){div = document.getElementById('aanumbersresults');}
	else {
		div = document.createElement('div'); ft = document.getElementById('footer'); trg = ft.parentNode;
		div.id = 'aanumbersresults';
		trg.insertBefore(div, ft);
	}
	div.innerHTML = newContent;
	newContent = "<div class=\"container margin-top-70 margin-bottom-90\"><div class=\"row margin-bottom-60\"><div class=\"col-md-12\">";
})();
}}

Tested in the console and will work if implemented as suggested.

However, I would also suggest a few other minor changes for cosmetic (layout), and ease of future editing. But let's get this part working first.

**chechu** · 02-27-2018, 08:17 AM

Works like a charm, John.
What cosmetics would you like to add/remove?
Thanks!

**jscheuer1** · 02-27-2018, 04:15 PM

Well, just two (or three, depending how you count them) things. First of all, at the beginning, were we have, I'd add the highlighted:

Code:

// globale variabelen
var newWindow;
var newContent = "<div class=\"container margin-top-50 margin-bottom-90\"><div class=\"row margin-bottom-60\"><div class=\"col-md-12\">";
var newContentBak = newContent;

That way, we won't have to retype it later, so can change the added code as shown:

Code:

;(function(){
	var div, ft, trg;
	if(document.getElementById('aanumbersresults')){div = document.getElementById('aanumbersresults');}
	else {
		div = document.createElement('div'); ft = document.getElementById('footer'); trg = ft.parentNode;
		div.id = 'aanumbersresults';
		trg.insertBefore(div, ft);
	}
	div.innerHTML = newContent;
    newContent = newContentBak;
})();
}}

That will make it easier should you ever want to change the vertical spacing or any other characteristics of the result that are controlled there. You indicated before that you might. If you do, then go back to the beginning and make it (or try other changes if you prefer, or leave as is if you like, the main thing is it only needs to be changed in one place now, not two):

Code:

// globale variabelen
var newWindow;
var newContent = "<div class=\"container\" style='margin-top: -100px;'><div class=\"row\"><div class=\"col-md-12\">";
var newContentBak = newContent;