Page 1 of 2 12 LastLast
Results 1 to 10 of 20

Thread: Would you mind checking my code

  1. #1
    Join Date
    Nov 2011
    Location
    Cider Region
    Posts
    1,085
    Thanks
    157
    Thanked 3 Times in 3 Posts

    Default Would you mind checking my code

    Morning,
    I was having problems with some pages so i decided to start again.
    Im 99% happy apart from one page.

    Here is a page with working videos & are vied & placed perfect on pc & phone.
    Code:
    http://www.theremotedoctor.co.uk/honda_flip_remote_upgrade.html?scrollto=secondary-navigation
    Here is the new page now with just one video
    http://www.theremotedoctor.co.uk/new...les_video.html

    Pc is great but what i see on my phone is almost there but i missed something when i was copying/editing text from one file to another.
    As you can see in the screenshot below the video is outside of the blue boder,buy why ?
    Once you click play it fine.

    This is the view on see on my phone.
    Click image for larger version. 

Name:	screenshot.jpg 
Views:	303 
Size:	55.3 KB 
ID:	5802

    Please could you assist where i went wrong.
    Last edited by theremotedr; 01-25-2016 at 05:14 PM.

  2. #2
    Join Date
    Nov 2006
    Location
    chertsey, a small town 25 miles south west of london, england.
    Posts
    1,336
    Thanks
    1
    Thanked 241 Times in 236 Posts

    Default

    Hi there theremotedr,


    change this CSS...

    Code:
    
    .ebayvideo {
        width:640px;
        margin:5px auto;
    	border: 2px #000099 solid;
    ...to this...
    Code:
    
    .ebayvideo {
        max-width:640px;
        margin:5px auto;
        border:2px solid #009;
        box-shadow:2px 2px 8px rgba(0,0,0,0.50);
     }
    #ebayvideo {
        display:block;
        width:100%;
     }

    coothead
    ~ the original bald headed old fart ~

  3. The Following User Says Thank You to coothead For This Useful Post:

    theremotedr (01-23-2016)

  4. #3
    Join Date
    Jul 2008
    Location
    Derbyshire, UK
    Posts
    3,033
    Thanks
    25
    Thanked 599 Times in 575 Posts
    Blog Entries
    40

    Default

    Short answer - if you have a page that works/looks right already, use that as a base and copy and paste in the new details again but more carefully.

    You've been coding long enough now to work through the logic of these simple problems yourself.

    Sorry to be blunt but our time is as valuable as yours.
    Focus on Function Web Design
    Fast Edit (A flat file, PHP web page editor & CMS. Small, FREE, no database!) | Fast Edit BE (Snippet Manager) (Web content editor for multiple editable regions!) | Fast Apps

  5. #4
    Join Date
    Nov 2011
    Location
    Cider Region
    Posts
    1,085
    Thanks
    157
    Thanked 3 Times in 3 Posts

    Default

    Quote Originally Posted by Beverleyh View Post
    Short answer - if you have a page that works/looks right already, use that as a base and copy and paste in the new details again but more carefully.

    You've been coding long enough now to work through the logic of these simple problems yourself.

    Sorry to be blunt but our time is as valuable as yours.
    Hmmm,
    But you will make mistakes and isnt that the point of this form where people help each other out.
    I thought this was a place to come when you have finished work etc ?

    Not being rude but if you are busy dont reply to my posts,only when yopu have time etc.

  6. #5
    Join Date
    Jul 2008
    Location
    Derbyshire, UK
    Posts
    3,033
    Thanks
    25
    Thanked 599 Times in 575 Posts
    Blog Entries
    40

    Default

    There's more to it than replying or not replying. Part of a moderator's work here is to manage time-wasting threads so that all members who can assist can concentrate on answering questions effectively. We've helped you numerous times in the past and we would hope that you have taken our advice on board, such as using a code validator, checking your own work against other working examples, using the developer toolbar, Googling to check compatability, etc. There's a certain amount of experience that is to be expected from somebody with your post count, and a balance earned from reciprocating help towards others. Maybe you could try to offer help so that your time here is more balanced? Offsetting the knowledge and time already given by those who have helped you. Just a thought.
    Focus on Function Web Design
    Fast Edit (A flat file, PHP web page editor & CMS. Small, FREE, no database!) | Fast Edit BE (Snippet Manager) (Web content editor for multiple editable regions!) | Fast Apps

  7. The Following User Says Thank You to Beverleyh For This Useful Post:

    Ripsaw (01-23-2016)

  8. #6
    Join Date
    Jan 2016
    Posts
    23
    Thanks
    49
    Thanked 3 Times in 2 Posts

    Default

    Quote Originally Posted by theremotedr
    isnt that the point of this form where people help each other out.
    Sure is, but the lady has a point. "Help each other out" is kinda one sided when the purpose of all of your posts is seeking help for your own issues -- look at your topics in your members page sometime

  9. #7
    Join Date
    Nov 2011
    Location
    Cider Region
    Posts
    1,085
    Thanks
    157
    Thanked 3 Times in 3 Posts

    Default

    I am obviously not advanced enough to give advise when members are so far in front.
    I do try to sort things myself before i come here.

  10. #8
    Join Date
    Nov 2006
    Location
    chertsey, a small town 25 miles south west of london, england.
    Posts
    1,336
    Thanks
    1
    Thanked 241 Times in 236 Posts

    Default

    Hi there theremotedr,

    it seems to be a bash-theremotedr-day today.

    Don't worry too much about it, though.

    You still got your problem solved and, of course,
    tomorrow is another day.

    coothead
    ~ the original bald headed old fart ~

  11. The Following User Says Thank You to coothead For This Useful Post:

    theremotedr (01-23-2016)

  12. #9
    Join Date
    Nov 2011
    Location
    Cider Region
    Posts
    1,085
    Thanks
    157
    Thanked 3 Times in 3 Posts

    Default

    Cheers Coothead,
    I changed the code and working well.
    Now im sorted & looking forward to tomorrow.
    The old page wasnt the same set up as the new page hence why it didnt go straight forward.

  13. #10
    Join Date
    Nov 2006
    Location
    chertsey, a small town 25 miles south west of london, england.
    Posts
    1,336
    Thanks
    1
    Thanked 241 Times in 236 Posts

    Default

    Hi there theremotedr,

    Now I'm sorted & looking forward to tomorrow.
    Well, there you go, that's definitely the right attitude....


    coothead
    ~ the original bald headed old fart ~

Similar Threads

  1. Resolved Newbie requires code checking please
    By theremotedr in forum JavaScript
    Replies: 2
    Last Post: 04-12-2015, 08:04 PM
  2. Checking Code vs different browsers
    By mcolton in forum HTML
    Replies: 5
    Last Post: 03-01-2012, 03:35 PM
  3. Checking 4 Domain...good Code Bad Writer
    By sasha hantz in forum JavaScript
    Replies: 1
    Last Post: 06-24-2007, 03:46 PM
  4. Mind stopped working
    By vaibhav24in in forum JavaScript
    Replies: 2
    Last Post: 02-12-2007, 11:05 AM
  5. value transfer to popup (a mind bender)
    By kusalo in forum JavaScript
    Replies: 2
    Last Post: 09-12-2006, 08:15 AM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •