Need some direction with this script

[traq]

Is this still the warning you get?

Warning: mysql_num_rows() expects parameter 1 to be resource, boolean given in /home/userdir/foobar/guid-checker.php on line ...

mysqli_query() returns a mysqli_result object if the query is successful, but returns boolean FALSE if there was a problem. Since you don't check, you're ending up passing FALSE to mysqli_num_rows(), when it expects the object - hence, your error message.

/* snip */
$result = $mysqli->query($query);

# right about here, you should be checking if the query was successful or not.

    if (mysql_num_rows($result)<1){
/* snip */ 

[djr33]

Looks like it's mixing mysqli and mysql. Is that ok?

[traq]

Looks like it's mixing mysqli and mysql. Is that ok?

I did not notice that. Nope, not okay, won't work. itivae, you're missing an i in mysqli_num_rows().

However, that's not what's causing this particular error. You still need to be checking if your query was successful before trying to use it. I would also suggest not mixing object-oriented (e.g., $mysqli->query()) and procedural (e.g., mysqli_num_rows()) styles - choose one or the other.

[Beverleyh]

Speaking of editors, you'd do well to choose one with syntax highlighting. It makes a world of difference.

I changed your posts above to use [PHP] tags instead of simple [CODE] tags - as you can see, the error becomes very obvious.

PSPad http://www.pspad.com/ and Notepad++ http://notepad-plus-plus.org/ as suggested earlier, both have syntax highlighting

[itivae]

Thanks for the suggestions. I use several text editors that all have syntax highlighting. I have made some headway on this code but am running into a problem when I try to INSERT data into the database. I have tried using mysqli_query() but I am not getting the confirmation or the error text. Just a blank screen. I have commented on the point that the code works till. Any suggestions would be much appreciated.

<?php
require_once('connectvars.php');
 $mysqli = new mysqli(DB_HOST, DB_USER, DB_PASSWORD, DB_NAME);

    /* check connection */
if ($mysqli->connect_errno) {
    printf("Connect failed: %s \n", $mysqli->connect_error);
    exit();
        } 
        
    $player_name = 'itivae'; //$_POST['playername'];    
    $player_id = '1010103'; //$_POST['playerid'];    
    $guid = '4e72f140c35df55909ce551273c44007'; //$_POST['guid'];
    
    /*if(!isset($_POST['playernam']) ||
        !isset($_POST['playerid']) ||
        !isset($_POST['guid']) || {
        died('We are sorry, but there appears to be a problem with the form you submitted.');       
    }*/

     
 
    $query = "SELECT * FROM player_bans WHERE banned_guid = '$guid'";


 if ($result = $mysqli->query($query)){
while ($obj = $result->fetch_object()) {
        
       printf ('<div class="bans">'."%s", $obj->banned_guid);
       printf (" appears in the ban list" . '</div>');
    }
} //WORKS TILL HERE

 else {

    $query = "INSERT INTO player_data (player_name, player_id, guid) 
    VALUES ('$player_name', '$player_id', '$guid')"; 
        $result = $mysqli->query($query);
    if ( false===$result ) {
  printf("error: %s\n", mysqli_error($mysqli));
}
else {
     echo 'Player: ' . $player_name . ' ' . $player_id . ' ' . $guid . ' has been added to the whitelist.';
    }
   
}
$mysqli->close();

?>

[traq]

... but I am not getting the confirmation or the error text. Just a blank screen.

That is almost always an indication that there was an error, and that your server is configured to prevent display of the error message.

This is fairly common with web hosting companies. You need to adjust your error reporting settings in your php.ini file, find your server's error log, and/or talk to your web host about how to do so.

[djr33]

Specifically, it is a parse error-- nothing is displayed because there is a problem understanding the code, so nothing is displayed. (Runtime errors, those found when trying to execute the script, are less severe and will show you at least some content-- a parse error stops the script from executing at all.)

Most frequently parse errors come from a missing ; or ) or }, but there can be other reasons too.

[itivae]

Specifically, it is a parse error-- nothing is displayed because there is a problem understanding the code, so nothing is displayed. (Runtime errors, those found when trying to execute the script, are less severe and will show you at least some content-- a parse error stops the script from executing at all.)

Most frequently parse errors come from a missing ; or ) or }, but there can be other reasons too.

But other parse errors where returned as a message....does that mean that some do and some dont? I have spoken with my host and it looks like error_reporting is fully enabled..... I am still getting a blank screen..... Any other thoughts?

[djr33]

Are you certain they were parse errors, not runtime errors? The error messages look very similar, but the first word will be different.

If you want to test it, you can try to run this as a new .php file:

<?php if( ?>

When I run that, I get the following error:

Parse error: syntax error, unexpected ';' in /home/.../test.php on line 1

If you get that error, it means you have error reporting enabled. If not, there is a problem with error reporting.





Edit: on an unrelated note, that's a weird error. I wonder why it claims there is a ';' when there isn't one in the code at all. Traq, any ideas?
I suppose it really means "the end came too early", and it's just not phrased well.
PHP has some weird error messages (but you learn to understand them with time). One of them (in the English version of PHP) is actually written in Indonesian-- some kind of weird typo!

[itivae]

when I run that as a new .php file I get the following error:

Parse error: syntax error, unexpected ';' in /home/userdir/foobar/errortest.php on line 1