Need some direction with this script

**itivae** · 03-13-2013, 08:23 PM

Hi i am writing a script to check a guid against a column in a database. Here is what I have so far but I keep getting a "Parse error: syntax error, unexpected T_STRING in /home/mydir/foobar/guid-checker.php on line 39"

PHP Code:


<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

<html>
<head>
<title>guid check</title>
<link rel="stylesheet" type="text/css" href="style.css" />
</head>
<body>
<?php
require_once('connectvars.php');

    $player_name = 'itivae'; //$_POST['playername'];    
    $player_id = '1010103'; //$_POST['playerid'];    
    $guid = '4e72f140c35df55909ce551273c44006'; //$_POST['guid'];
    
    /*if(!isset($_POST['playernam']) ||
        !isset($_POST['playerid']) ||
        !isset($_POST['guid']) || {
        died('We are sorry, but there appears to be a problem with the form you submitted.');       
    }*/
   $mysqli = new mysqli(DB_HOST, DB_USER, DB_PASSWORD, DB_NAME);
/* check connection */
if ($mysqli->connect_errno) {
    printf("Connect failed: %s\n", $mysqli->connect_error);
    exit();
        }  
        $query = "SELECT banned_guid, player_id, player_name FROM player_data WHERE banned_guid = $guid; 
    
    if ($result = $mysqli->query($query)) {

    if (mysql_num_rows($result)>0) {
    printf ('Unapproved ' . $guid . ' ' . 'matches a guid on the ban list.');
   }  
}    

else {

    
    $query ="INSERT INTO player_data (player_name, player_id, guid)
 VALUES ('itivae', '1010103', '4e72f140c35df55909ce551273c44006')";
echo 'This player ' . $player_name. ' ' . $player_id . ' ' . $guid . ' has been added to the whitelist.');
}

$mysqli->close();

?>
</body>
</html>

Any help is appreciated. I may not even be going about this in the right manner as I am still new with php.

Thanks in advance.

**Beverleyh** · 03-13-2013, 08:58 PM

Here's some info on what that error means and how to fix it: http://www.ehow.com/info_8717984_php...ed-string.html

You'll need an editor with line numbering to make finding the problem easier - PSPad http://www.pspad.com/ and Notepad++ http://notepad-plus-plus.org/ are both free ones that should help, so open the guid-checker.php file in one of those and check line 43.

**itivae** · 03-13-2013, 09:13 PM

Hi Beverleyh,

Thanks for the information. I have removed a great deal of the code (in an attempt to get at least part of it working correctly so that I have something to work off of), I am still getting a T_STRING error but now it is past the last line of code. I cannot see any glaring syntax errors (but maybe I have become blind to them after several hours).

Here is the code I am working with:

PHP Code:


<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

<html>
<head>
<title>guid check</title>
<link rel="stylesheet" type="text/css" href="style.css" />
</head>
<body>
<?php
require_once('connectvars.php');

    $player_name = 'itivae'; //$_POST['playername'];    
    $player_id = '1010103'; //$_POST['playerid'];    
    $guid = '4e72f140c35df55909ce551273c44006'; //$_POST['guid'];
    
    /*if(!isset($_POST['playernam']) ||
        !isset($_POST['playerid']) ||
        !isset($_POST['guid']) || {
        died('We are sorry, but there appears to be a problem with the form you submitted.');       
    }*/
   $mysqli = new mysqli(DB_HOST, DB_USER, DB_PASSWORD, DB_NAME);
/* check connection */
if ($mysqli->connect_errno) {
    printf("Connect failed: %s\n", $mysqli->connect_error);
    exit();
        }  
    $query = "SELECT banned_guid, player_id, player_name FROM player_data WHERE banned_guid = $guid"; 
    
    if ($result = $mysqli->query($query)) {

    if (mysql_num_rows($result)>0) {
    printf ('Unapproved ' . $guid . ' ' . 'matches a guid on the ban list.');
   }  
    }     

else {
echo 'This worked';
}


$mysqli->close();


?>
</body>
</html>

**itivae** · 03-13-2013, 09:31 PM

Oh *&%(*%(.....There is a missing " on line 41. Thanks for the help. I am going to leave this thread open for a minute in case I have another problem.

**itivae** · 03-13-2013, 11:39 PM

So I have played with this a little more. Its seems to run but it is not accomplishing all of its tasks. It skips the first if statment and always evaluates to true making the "else" statment always run even when its false. I was hoping somone might have an idea of what I am doing wrong. Here is the displayed text:
"Warning: mysql_num_rows() expects parameter 1 to be resource, boolean given in /home/userdir/foobar/guid-checker.php on line 31
This player itivae 1010103 4e72f140c35df55909ce551273c44006 has been added to the whitelist.

Here is the current code

PHP Code:


<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

<html>
<head>
<title>guid check</title>
<link rel="stylesheet" type="text/css" href="style.css" />
</head>
<body>
<?php
require_once('connectvars.php');

    $player_name = 'itivae'; //$_POST['playername'];    
    $player_id = '1010103'; //$_POST['playerid'];    
    $guid = '4e72f140c35df55909ce551273c44006'; //$_POST['guid'];
    
    /*if(!isset($_POST['playernam']) ||
        !isset($_POST['playerid']) ||
        !isset($_POST['guid']) || {
        died('We are sorry, but there appears to be a problem with the form you submitted.');       
    }*/
   $mysqli = new mysqli(DB_HOST, DB_USER, DB_PASSWORD, DB_NAME);
/* check connection */
if ($mysqli->connect_errno) {
    printf("Connect failed: %s\n", $mysqli->connect_error);
    exit();
        }  
    $query = "SELECT banned_guid FROM player_bans WHERE banned_guid = $guid"; 

 $result = $mysqli->query($query);

    if (mysql_num_rows($result)>0){

    printf ('Unapproved ' . $guid . ' ' . 'matches a guid on the ban list.');
    
   } 
    

else {



    $query ="INSERT INTO player_data (player_name, player_id, guid) VALUES ('itivae', '1010103', '4e72f140c35df55909ce551273c44006')";
echo 'This player ' . $player_name. ' ' . $player_id . ' ' . $guid . ' has been added to the whitelist.';
}

$mysqli->close();

?>
</body>
</html>

This always runs the else text but does not INSERT anything into the player_data table.

Thanks

**traq** · 03-13-2013, 11:41 PM

Speaking of editors, you'd do well to choose one with syntax highlighting. It makes a world of difference.

I changed your posts above to use [PHP] tags instead of simple [CODE] tags - as you can see, the error becomes very obvious.

**itivae** · 03-13-2013, 11:49 PM

Pardon my ignorance but could you please be a little more specific?

**djr33** · 03-14-2013, 12:19 AM

Compare the good code and the bad code, paying close attention to the red parts. Look for patterns. With some practice you'll see it very quickly.

**traq** · 03-14-2013, 01:30 AM

Text editors desgined for coding (or simply to accommodate coding) highlight different parts of your code in different ways, to help distinguish them. It's much easier to have everything color-coded than to stare at a long line of black-and-white gibberish, looking for a missing double-quote. The syntax highlighting used by the forum's [PHP] tags, for example, makes string values red, variable names blue, function names green, comments yellow, etc.:

PHP Code:


<?php

$thisIsAVariable = "this is a string";

/* this is a comment */
thisIsAFunction( $thisIsAVariable );

Now, if you'd forgotten the closing double-quote on your string, you'd get a fatal error (something like "unexpected $end," in this case). But you'd be able to find the problem almost instantly, because you'd notice that your string was much larger than you intended it to be:

PHP Code:


<?php

$thisIsAVariable = "this is a string;

/* this is a comment */
thisIsAFunction( $thisIsAVariable );

cool, huh?

**itivae** · 03-14-2013, 01:34 AM

Alright I have been staring at this for more than an hour.... I have tried to rearrange the code. I am really stumped. Here is my current code....Feel free to hint at the answers...

PHP Code:


<?php
require_once('connectvars.php');

    $player_name = 'itivae'; //$_POST['playername'];    
    $player_id = '1010103'; //$_POST['playerid'];    
    $guid = '4e72f140c35df55909ce551273c44007'; //$_POST['guid'];
    
    /*if(!isset($_POST['playernam']) ||
        !isset($_POST['playerid']) ||
        !isset($_POST['guid']) || {
        died('We are sorry, but there appears to be a problem with the form you submitted.');       
    }*/
   $mysqli = new mysqli(DB_HOST, DB_USER, DB_PASSWORD, DB_NAME);
/* check connection */
if ($mysqli->connect_errno) {
    printf("Connect failed: %s \n", $mysqli->connect_error);
    exit();
        }  
    $query = "SELECT * FROM player_bans WHERE banned_guid='$guid'"; 

 $result = $mysqli->query($query);


    if (mysql_num_rows($result)<1){
    $query = "INSERT INTO player_data (player_name, player_id, guid) VALUES ('itivae', '1010103', '4e72f140c35df55909ce551273c44007')";
 echo 'This player ' . $player_name . ' ' . $player_id . ' ' . $guid . ' has been added to the whitelist.';
    
   } 
    

else {

   echo 'Unapproved ' . $guid .  ' matches a guid on the ban list.';


}
$mysqli->close();

?>

Am I any closer? Do I need to look at the db connection closer? It seems to not trigger the error message so I am assuming it is connected (you know what they say about assumptions though). These are two separate tables I don't think I need a new connection for each db update but like I said I am not overly proficient with php and MySQL. Also on the INSERT INTO line is there supposed to be any syntax between the definition of the columns and the values inserted into the columns? From what I have read that string seems acceptable. Thanks for taking the time.