Problem with combining two scripts together

**Irin** · 12-27-2005, 03:30 AM

Hello,

I have a problem with combining two javascripts together. I'm using Adobe ImageReady rollover effect in my top navigation bar. The code is:

<script type="text/javascript">

</script>

Now, I want to add "Conveyor Belt slideshow script" from Dynamic Drive. The code I want to use is:

The problem I have is when I insert this Dynamic Drive script, my Adobe ImageReady rollover effect stops working.

Does anybody can advise me on how I can combine two scripts together. Any help would be greatly appreciated.

Thanks in advance,
Irin.

**jscheuer1** · 12-27-2005, 04:23 AM

What does your body tag look like? Does it have something like this in it? -

HTML Code:

<body onload="preloadImages();">

If so, remove the line:

Code:

window.onload=fillup

and change the onload event in the body tag to:

HTML Code:

<body onload="preloadImages();fillup();">

If this is not what is happening then:

PLEASE: Include the URL to your problematic webpage that you want help with.

**Irin** · 12-27-2005, 04:35 AM

Thanks a lot, John. It's all working now. You awesome.

Thank,
Irin.

**Irin** · 12-28-2005, 03:37 AM

Hi,

Now I got a problem with using a different script with my Adobe ImageReady script. The one I'm trying to integrate requires adding the following code into <head>:

And the following code into <body>:

<form NAME="form" ACTION>
<p>
<input TYPE="text" NAME="substring" SIZE="35"> </p><p> <input TYPE="button" VALUE="Start" ONCLICK="{clearTimeout(banner_id); b_position=0; banner_main()}">
<input TYPE="button" VALUE="Slow" ONCLICK="{if(b_speed<10){alert("Going Slow!")}else{b_speed=b_speed-5}}">
<input TYPE="button" VALUE="Fast" ONCLICK="{if(b_speed>25){alert("Going Fast!")}else{b_speed=b_speed+5}}">
<input TYPE="button" VALUE="Pause/Reset" ONCLICK="stop()"> </p>
</form>

This script gives me a window for scrolling message to run and buttons Start, Slow, Fast, Pause/Reset underneath it. If I use an Adobe ImageReady rollover effect (the code is above in my first post) in my top navigation bar with this "scrolling message" effect, the "scrolling message" effect doesn't work. When I click Start to launch scrolling message, I'm getting the following Internet Explorer Script Error:

An error has occured in the script on this page.
Line: 173
Char: 1
Error: 'document.forms.0.substring' is null or not an object
Code: 0
URL: ....
Do you want to continue running scripts on this page? Yes/No

Line 173 says: banner_id=setTimeout("banner_main()",1000/b_speed)}

Any help would be greatly appreciated. Thanks in advance,
Irin.

**jscheuer1** · 12-28-2005, 05:29 AM

Are you running a Mac, or some older version of IE, or IE emulation under another browser? That type of yes/no error message went out with IE6. Anyways, it doesn't look like one script is doing anything to the other. However, this looks plain wrong:

Code:

document.forms[0].substring.value=msg.substring(b_position,b_position+250);

It should be something like this:

Code:

document.forms[0].value=msg.substring(b_position,b_position+250);

At least I would think so, give it a shot.

**Irin** · 12-28-2005, 05:45 AM

Hi John,

I'm running IE6. I tryed replacing

document.forms[0].substring.value=msg.substring(b_position,b_position+250);

with

document.forms[0].value=msg.substring(b_position,b_position+250);

Now, I'm not getting an error message but when I click Start button nothing happens, the scrolling message is not running at all.
There is still something wrong with the script. Any other ideas?

Thanks a lot for your help.

**jscheuer1** · 12-28-2005, 06:03 AM

I put the two scripts (the preload script and the scroller script) on a fresh page for testing. Just copied them from your messages and pasted them into my page, adding:

onload="preloadImages();"

to the body tag. The scroller worked fine, so I am at a loss except that it may be the menu code itself that is the problem or some other error I cannot see from what you have given me.

PLEASE: Include the URL to your problematic webpage that you want help with.

**Irin** · 12-28-2005, 06:32 AM

The url is: h**p://test.tvielectronics.com/Products/TC553-852_Controller.html. This page is for testing purposes only. I'm currently running updates on my web site.

Thanks.

**jscheuer1** · 12-28-2005, 07:08 AM

First of all, go back to the original script, then change forms[0] to forms[1]:

Code:

<script LANGUAGE="javascript">

var b_speed=10;
var banner_id=1;
var b_pause=0;
var b_position=0;
function stop(){
  if(!b_pause){
    clearTimeout(banner_id);
    b_pause=1}
else{
    banner_main();
    b_pause=0}}
function banner_main(){
  msg="                             This feature adds a scrolling message to your project.";
  var k=(150/msg.length)+1;
  for(var j=0;j<k;j++)msg+=""+msg;

document.forms[1].substring.value=msg.substring(b_position,b_position+250);
  if(b_position++==250){
    b_position=0}
  banner_id=setTimeout("banner_main()",1000/b_speed)}

</script>

Because there is another form on your page above the scroller's, it is no longer forms[0] (the first form on the page) but forms[1] (the second form on the page.

**Irin** · 12-28-2005, 07:16 AM

You're right again. It was that easy

. Everything is working now. Thanks so much.

Thread: Problem with combining two scripts together

Thread Tools

Search Thread

Problem with combining two scripts together

Bookmarks

Bookmarks

Posting Permissions