Another error

[keyboard]

hey everyone,

<?php

require "database.php";
$userfinal=$_COOKIE['ID_my_site'];  
$user=$userfinal;
echo $user;






 if (isset($_POST['submit'])) {

echo "Thanks";

$title=$_POST['message_title'];
$to=$_POST['message_to'];
$content=$_POST['message_content'];
$from=$_POST['message_from'];
$time=$_POST['message_date'];


$ck_reciever = "SELECT username FROM users WHERE username = '".$to."'";

        
   
        if( mysql_num_rows( mysql_query( $ck_reciever ) ) == 0 ){
die("The user you are trying to contact don\'t excist. Please go back and try again.<br> ");
}





 else 
{
?>     
 <form name="message" action="new_message.php" method="post">
 Title:  <input type="text" name="message_title"> <br>
 To:   <input type="text" name="message_to"> <br>
      Message: <br>
<textarea rows="20" cols="50" name="message_content">
</textarea>
<?php
echo '<input type="hidden" name="message_from" value="'.$user.'"><br>';
?>
<input type="submit" name="submit" value="Submit">
</form>

<?php
 }
 ?>

Causing this error

( ! ) Parse error: syntax error, unexpected $end in C:\Documents and Settings\Owner\Desktop\canberra amatuer productions\www\Canberra Amatuer Productions\pm system\new_message.php on line 59


Can't work out why. Any help?

[JShor]

You never ended this line with a }:

if (isset($_POST['submit'])) { 

Try this:

<?php

require "database.php";
$userfinal=$_COOKIE['ID_my_site'];  
$user=$userfinal;
echo $user;






 if (isset($_POST['submit'])) {

echo "Thanks";

$title=$_POST['message_title'];
$to=$_POST['message_to'];
$content=$_POST['message_content'];
$from=$_POST['message_from'];
$time=$_POST['message_date'];


$ck_reciever = "SELECT username FROM users WHERE username = '".$to."'";

        
   
        if( mysql_num_rows( mysql_query( $ck_reciever ) ) == 0 ){
die("The user you are trying to contact don\'t excist. Please go back and try again.<br> ");
}





 else 
{
?>     
 <form name="message" action="new_message.php" method="post">
 Title:  <input type="text" name="message_title"> <br>
 To:   <input type="text" name="message_to"> <br>
      Message: <br>
<textarea rows="20" cols="50" name="message_content">
</textarea>
<?php
echo '<input type="hidden" name="message_from" value="'.$user.'"><br>';
?>
<input type="submit" name="submit" value="Submit">
</form>

<?php
 }
 
 }
 ?>

[keyboard]

<?php

require "database.php";
$userfinal=$_COOKIE['ID_my_site'];  
$user=$userfinal;
echo $user;







 if (isset($_POST['submit'])) {

echo "Thanks";

$title=$_POST['message_title'];
$to=$_POST['message_to'];
$content=$_POST['message_content'];
$from=$_POST['message_from'];
$time=$_POST['message_date'];


$ck_reciever = "SELECT username FROM users WHERE username = '".$to."'";

        
   
        if( mysql_num_rows( mysql_query( $ck_reciever ) ) == 0 ){
die("The user you are trying to contact don\'t excist. Please go back and try again.<br> ");
}


 $insert = "INSERT INTO pmsys (to, from, title, message, date, ifread)
             VALUES ('".$to."', '".$from."', '".$title."', '".$content."', '".$date."', '".$ifread."')";
     $add_member = mysql_query($insert);




 else 
{
?>     
 <form name="message" action="new_message.php" method="post">
 Title:  <input type="text" name="message_title"> <br>
 To:   <input type="text" name="message_to"> <br>
      Message: <br>
<textarea rows="20" cols="50" name="message_content">
</textarea>
<?php
echo '<input type="hidden" name="message_from" value="'.$user.'"><br>';
?>
<input type="submit" name="submit" value="Submit">
</form>

<?php
 }
 
 }
 ?>

Somewhere it's causing this error

( ! ) Parse error: syntax error, unexpected T_ELSE in C:\Documents and Settings\Owner\Desktop\canberra amatuer productions\www\Canberra Amatuer Productions\pm system\new_message.php on line 41

I'm 99% sure it in here

 $insert = "INSERT INTO pmsys (to, from, title, message, date, ifread)
             VALUES ('".$to."', '".$from."', '".$title."', '".$content."', '".$date."', '".$ifread."')";
     $add_member = mysql_query($insert); 

[bluewalrus]

It's caused by

else 
{
?>     
 <form name="messa 

The error message provides you with a lot of information

( ! ) Parse error: syntax error, unexpected T_ELSE in C:\Documents and Settings\Owner\Desktop\canberra amatuer productions\www\Canberra Amatuer Productions\pm system\new_message.php on line 41

When is this suppose to execute if the condition is met or isnt?

 $insert = "INSERT INTO pmsys (to, from, title, message, date, ifread)
             VALUES ('".$to."', '".$from."', '".$title."', '".$content."', '".$date."', '".$ifread."')";
     $add_member = mysql_query($insert); 

[keyboard]

If the form has been submitted, It will upload it to the database. Otherwise It will display the form.
The error only started when I put this code in

 $insert = "INSERT INTO pmsys (to, from, title, message, date, ifread) 
             VALUES ('".$to."', '".$from."', '".$title."', '".$content."', '".$date."', '".$ifread."')"; 
     $add_member = mysql_query($insert); 

[bluewalrus]

Okay so you just need to add a curly brace before the else

 $insert = "INSERT INTO pmsys (to, from, title, message, date, ifread)
             VALUES ('".$to."', '".$from."', '".$title."', '".$content."', '".$date."', '".$ifread."')";
     $add_member = mysql_query($insert);




 } else 
{ 

[keyboard]

?php

require "database.php";
$userfinal=$_COOKIE['ID_my_site'];  
$user=$userfinal;
echo $user;







 if (isset($_POST['submit'])) {

echo "Thanks";

$title=$_POST['message_title'];
$to=$_POST['message_to'];
$content=$_POST['message_content'];
$from=$_POST['message_from'];
$time=$_POST['message_date'];


$ck_reciever = "SELECT username FROM users WHERE username = '".$to."'";

        
   
        if( mysql_num_rows( mysql_query( $ck_reciever ) ) == 0 ){
die("The user you are trying to contact don\'t excist. Please go back and try again.<br> ");


 $insert = "INSERT INTO pmsys (to, from, title, message, date, ifread) 
             VALUES ('".$to."', '".$from."', '".$title."', '".$content."', '".$date."', '".$ifread."')"; 
     $add_member = mysql_query($insert); 




 } else  
{ 
?>     
 <form name="message" action="new_message.php" method="post">
 Title:  <input type="text" name="message_title"> <br>
 To:   <input type="text" name="message_to"> <br>
      Message: <br>
<textarea rows="20" cols="50" name="message_content">
</textarea>
<?php
echo '<input type="hidden" name="message_from" value="'.$user.'"><br>';
?>
<input type="submit" name="submit" value="Submit">
</form>

<?php
 }
 
 }
 ?>

Is that how it should look because when I open it the whole page is blank

[traq]

if you don't have the cookie set, or $_POST['submit'], then you should get a blank page.


1) if there's no cookie, then $user will be empty, and echo will print nothing.

2) then, if the form was not submitted (likely, as it was never displayed), the first if() will be FALSE, and execution will skip to the end of the script.

3) you're done, and nothing happened.
(I suspect your first if() conditional is supposed to end earlier than it does. Also, even if your form was submitted, you'd never insert any records because you die() right before the lines that query the db.)



Honestly, I would try rewriting this after planning out the structure a little more. All of your php code should come as early as possible, and be mostly (preferably completely) done by the time you start outputting html. Make a step-by-step outline of what needs to happen in php (if you do so here, I'll be happy to offer advice), then put the html at the end.

[djr33]

In addition to Traq's advice, if you for some reason want a blank page in certain circumstances, then for testing it will be a good idea to add some sort of feedback to be sure the page is working. A blank page can mean the page is not processing at all (there is some major error in parsing the PHP) or that there is nothing to show (no error, just no content). To fix that, you can add a single line at the end of your script, <?php echo 'Hello World'; ?>. This way at the very least you know your script has no parse errors. But generally you should just follow what Traq said.

[keyboard]

echo "Thanks"; 

Thats why I put that in