If condition for moving to another page

**rhodarose** · 03-10-2011, 06:00 AM

Good day!

I want to know what is wrong in my code that's why when i choose in select option it did not go to another page...Like when I select "Incoming" nothing happen also when I choose "Outgoing" nothing also happen.

Here is my code:

PHP Code:


<?php

include ("config.php");



$call_type = $_POST['call_type'];



$query=mysql_query("SELECT `call_type` FROM `tbl_calltype` WHERE `call_type` = '{$call_type}'") or die(mysql_error());

$result = mysql_num_rows($query);



if ($result == 1){



if($call_type == 'Incoming'){

    header ('Location:incoming.php');

}

elseif($call_type == 'Outgoing'){

    header ('Location:outgoing.php');

}

else{

    header('Location:index.php');

}

}

?>

<html>

<body>

<form id="form1" name="form1" method="post" action="">

  <select name="call_type">

    <option value="Select Call Type">Select Call Type</option>

    <option value="Incoming" <?php if($_POST['call_type'] == 'Incoming') echo "selected='selected'"; ?>>Incoming</option>

    <option value="Outgoing" <?php if($_POST['call_type'] == 'Outgoing') echo "selected='selected'"; ?>>Outgoing</option>

  </select>

</form>

</body>

</html>

Thank you

**traq** · 03-10-2011, 03:19 PM

a successful mysql_query doesn't return "1" (it returns a resource), so your first if() condition is false and the code is not executed.

try changing it to just if($result) instead

**djr33** · 03-10-2011, 11:26 PM

That will work. Here are two additional ways to approach it:

if ($result!==FALSE)
Also possible as:
if ($result!=0) (But that code is a bit lazy, since it really is finding a FALSE, not a 0).

Or:
if (mysql_num_rows($result)==1)
That might be what you wanted-- that's saying "if there's exactly one result".
You can also change that a bit for other cases. Change 1 to any number you'd like.
Or use a greater than operator:
if (mysql_num_rows($result)>5)
(If there are more than 5 rows)
if (mysql_num_rows($result)>=5)
(If there are 5 or more rows)
if (mysql_num_rows($result)!=0)
If the number of rows is not 0-- equivalent to the other options above-- if any rows were found...

But you can also do it a little more directly in some cases:
if ($row = mysql_fetch_assoc($result))
This code attempts to set $row as the first row found from the query (as an associative array). If it is successful, it will continue. If not, it will skip the next section. That's a very common way to use if statements with mysql queries, but not the only option.

**rhodarose** · 03-11-2011, 12:55 AM

I tried this code:

PHP Code:


<?php 

include ("config.php"); 



if (isset($_POST['call_type'])) { // Check if form has been submitted 

$call_type = mysql_real_escape_string($_POST['call_type']); // SECURE THE FECKING CONTENT!!!!!!!!!!!!!!!!!!!!!! 



echo $call_type; 



$query=mysql_query("SELECT `call_type` FROM `tbl_calltype` WHERE `call_type` = '{$call_type}'") or die(mysql_error()); 

$result = mysql_num_rows($query); 

echo '<br />' . $result;



/*if ($result == 1){ 

if($call_type == 'Incoming'){ 

    header ('Location:incoming.php'); 

} 

elseif($call_type == 'Outgoing'){ 

    header ('Location:outgoing.php'); 

} 

else{ 

    header('Location:index.php'); 

} 

}*/

} 

?> 

<html> 

<body> 

<form id="form1" name="form1" method="post" action=""> 

  <select name="call_type"> 

    <option value="Select Call Type">Select Call Type</option> 

    <option value="Incoming" <?php if($_POST['call_type'] == 'Incoming') echo "selected='selected'"; ?>>Incoming</option> 

    <option value="Outgoing" <?php if($_POST['call_type'] == 'Outgoing') echo "selected='selected'"; ?>>Outgoing</option> 

  </select> 

   

  <input type="submit" name = "Submit" value="Submit"> 

</form> 

</body> 

</html>

As you can see I add submit button.

The output of this code isv , when I choose Incoming and i press submit button the result is Incoming 1 and it was displayed in the same page. I want to happen is when I choose Incoming and I press submit button it will go to incoming.php:cry:

Thank you

**djr33** · 03-11-2011, 01:09 AM

$result = mysql_num_rows($query);

That line sets $result as the number of rows. Is that what you're trying to do?

**rhodarose** · 03-11-2011, 01:22 AM

Originally Posted by djr33

$result = mysql_num_rows($query);

That line sets $result as the number of rows. Is that what you're trying to do?

Yes...

**djr33** · 03-11-2011, 01:55 AM

I think I misread your code in the first post. (Maybe traq did too.)

What happens if you echo the name of the page instead of using a redirect? Just to test the value.

header('Location...') is supposed to have an absolute URL (including HTTP), but you are using just a filename. Change those to full URLs-- does that help?

**traq** · 03-11-2011, 02:38 AM

Am I correct in thinking that...

--you want to check if the "call_type" is a valid page
--if so, redirect to that page

?

If so, there are two options for you:

1) hard code.
--if the only options are "incoming" and "outgoing", and you don't plan on changing the options often, you can simply verify that the "call_type" is one or the other:

PHP Code:


// make an array containing the allowed values
$allowed_types = array('Incoming','Outgoing');

// check if the call_type is submitted, and (if so) that it matches one of the allowed values
if (isset($_POST['call_type']) && in_array($_POST['call_type'], $allowed_types)) {
  // if so, set the appropriate header()
  // you can use the value directly if it's the same as the filename
  header("Location: http://www.example.com/path/to/".$_POST['call_type'].".php"); 
}

looking at your example above, that's more than sufficient for what you're doing. however, you should use the database if you want the allowed pages to be more flexible:

PHP Code:


if (isset($_POST['call_type'])) {
  // escape the value
  $call_type = mysql_real_escape_string($_POST['call_type']);
  $result = mysql_query("SELECT `call_type` FROM `tbl_calltype` WHERE `call_type` = '{$call_type}' ");
  // if there's one row in the result, then there was a match.
  if(mysql_num_rows($result) === 1){
    // send the header()
    header("Location: http://www.example.com/path/to/".$call_type.".php"); 
  }
}

**rhodarose** · 03-11-2011, 04:56 AM

Originally Posted by traq

Am I correct in thinking that...

--you want to check if the "call_type" is a valid page
--if so, redirect to that page

?

If so, there are two options for you:

1) hard code.
--if the only options are "incoming" and "outgoing", and you don't plan on changing the options often, you can simply verify that the "call_type" is one or the other:

PHP Code:


// make an array containing the allowed values

$allowed_types = array('Incoming','Outgoing');



// check if the call_type is submitted, and (if so) that it matches one of the allowed values

if (isset($_POST['call_type']) && in_array($_POST['call_type'], $allowed_types)) {

  // if so, set the appropriate header()

  // you can use the value directly if it's the same as the filename

  header("Location: http://www.example.com/path/to/".$_POST['call_type'].".php"); 

}

looking at your example above, that's more than sufficient for what you're doing. however, you should use the database if you want the allowed pages to be more flexible:

PHP Code:


if (isset($_POST['call_type'])) {

  // escape the value

  $call_type = mysql_real_escape_string($_POST['call_type']);

  $result = mysql_query("SELECT `call_type` FROM `tbl_calltype` WHERE `call_type` = '{$call_type}' ");

  // if there's one row in the result, then there was a match.

  if(mysql_num_rows($result) === 1){

    // send the header()

    header("Location: http://www.example.com/path/to/".$call_type.".php"); 

  }

}

But it depends on what the user choose on the selection, to were the user will go.if the user choose Incoming it will go to incoming.php and if he choose outgoing it will go to outgoing.php

Thank you