Hello friends,

i can make a change on the following

1st of all it is an script when someone register if i set it for auto-accept it send to the user email X and if i set it for review before accept it send to the user email Y


2nd i'd like to change it os that i've already set it on review before accept hence i no need to if and else function since it direct no if and if not



here is the code below , i think it needs to remove some parts

Note : it act as ( store data - if auto send X if review send Y ) if X or Y working redirect user to signupsuccess if any error signupfail


after changes should be ( store data - if send or error just direct the user to signupsuccess )


here is the code ( the red my explain more )


Code:
<?php
session_start();
include_once('common/common.php');

DB_connect();
if (isset($tmpmemberID) && $tmpmemberID != "") {

	$SQL = "SELECT * FROM tmpmember WHERE tmpmemberID=$tmpmemberID";
	$result = mysql_query($SQL);
	$row = mysql_fetch_array($result);

	$title = $row['title'];
	$firstname = $row['firstname'];
	$lastname = $row['lastname'];
	$email = $row['email'];
	$address = $row['address'];
	$suburb = $row['suburb'];
	$state = $row['state'];
	$country = $row['country'];
	$postcode = $row['postcode'];
	$phone = $row['phone'];
	$mobile = $row['mobile'];
	$fax = $row['fax'];
	$username = $row['username'];
	$password = $row['password'];
	$membership = $row['membership'];
	$payment = $row['payment'];
	$websitename = WEB_NAME;
	$websitedomain = WEB_DOMAIN;
	$SQL = "SELECT DISTINCT * FROM membership WHERE memDuration = '$membership'";
	$result = mysql_query($SQL);
	$row = mysql_fetch_array($result);
	if ($row['memDesc'] == "")
		$memDesc = "blah blah blah";
	else
		$memDesc = $row['memDesc'];
	$SQL = "SELECT DISTINCT * FROM payment WHERE paymentID = '$payment'";
	$result = mysql_query($SQL);
	$row = mysql_fetch_array($result);
	if ($row['paymentName'] == "")
		$paymentName = "blah blah blah";
	else
		$paymentName = $row['paymentName'];
	$currentDate = date("YmdHis");
	$startDate = date("YmdHis");
	$length = $membership * 30;
	$expiryDate = date("YmdHis", mktime(date("H"), date("i"), date("s"), date("m"), date("d")+$length, date("Y")));
	$creation_date = convertdate($currentDate, true, true);
	$startdate = convertdate($startDate, true, false);
	$enddate = convertdate($expiryDate, true, false);

	if (MEMBER_REVIEW == "yes") { // put applicant's details in tmpmember table to allow review

		$SQL = "SELECT * FROM mailtemplate WHERE mailID=5";
		$result = mysql_query($SQL);
		$row = mysql_fetch_array($result);
		$mailtype = $row['type'];
		$subject = stripslashes($row['subject']);
		$subject = preg_replace('/\{(.+?)\}/e', '${"\1"}', $subject);
		$content = stripslashes($row['content']);
		$content = preg_replace('/\{(.+?)\}/e', '${"\1"}', $content);
		$result1 = true;
		$result2 = true;
		if ($result1 && $result2) {
			$headers .= "From: ".WEB_NAME." <".SALES_EMAIL.">\n";  // sender's name and email
			if ($mailtype == 0) {
				$headers .= "Content-Type: text/plain; charset=windows-1256\n"; // sets the mime type
			} else if ($mailtype == 1) {
				$headers .= "MIME-Version: 1.0\r\n";
				$headers .= "Content-type: text/html; charset=windows-1256\r\n";
			}
			$result2 = mail($email, $subject, stripslashes($content), $headers);
		}

	} else if (MEMBER_REVIEW == "no") { // grant applicant membership rightaway, right after processing

		$SQL = "SELECT * FROM mailtemplate WHERE mailID=3";
		$result = mysql_query($SQL);
		$row = mysql_fetch_array($result);
		$mailtype = $row['type'];
		$subject = stripslashes($row['subject']);
		$subject = preg_replace('/\{(.+?)\}/e', '${"\1"}', $subject);
		$content = stripslashes($row['content']);
		$content = preg_replace('/\{(.+?)\}/e', '${"\1"}', $content);
		$SQL1 = "INSERT INTO userdb VALUES(null, '$username', '$password', 0, 0, 1, $currentDate)";
		$SQL2 = "INSERT INTO member VALUES(null, '$title', '$firstname', '$lastname', '$email', '$address', '$suburb', '$state', '$country', '$postcode', '$mobile', '$phone', '$fax', '$membership', '$payment', $startDate, $expiryDate, LAST_INSERT_ID())";
		$result1 = mysql_query($SQL1);
		$result2 = mysql_query($SQL2);
		if ($payment != 0) {
			$memberID = mysql_insert_id();
			$SQL3 = "UPDATE transaction SET memberID=$memberID WHERE tmpmemberID=$tmpmemberID";
			$result3 = mysql_query($SQL3);
		}
		if ($result1 && $result2) {
			$SQL = "DELETE FROM tmpmember WHERE tmpmemberID=$tmpmemberID";
			$result1 = mysql_query($SQL);
			$headers .= "From: ".WEB_NAME." <".SALES_EMAIL.">\n";  // sender's name and email
			if ($mailtype == 0) {
				$headers .= "Content-Type: text/plain; charset=windows-1256\n"; // sets the mime type
			} else if ($mailtype == 1) {
				$headers .= "MIME-Version: 1.0\r\n";
				$headers .= "Content-type: text/html; charset=windows-1256\r\n";
			}
			$result2 = mail($email, $subject, stripslashes($content), $headers);
		}
	}
	DB_close();
	if ($result1 && $result2)
		openwindow(FILE_INDEX."?action=signupsuccess", SELF);
	else
		openwindow(FILE_INDEX."?action=signupfail", SELF);

}



?>
thanks in advance