Need help interpreting a mySQL function please

[kuau]

I have found this tres cool mySQL function to do exactly what I want, but the examples don't show me clearly how to use it in php. I am inserting an event record and need to add the categories associated with that event to another table at the same time, so I need the event_id (auto-incremented) to add to the 2nd table. So this is what I came up with:

First I insert the event record and then...

query = "SELECT LAST_INSERT_ID() FROM event ";
	$result = @mysql_query($query,$connection) or die("Couldn't execute $query query. <br> mysql error: ".mysql_error()); 
	$row = mysql_fetch_array($result);
	$neweventid = $row['event_id'];

Is there a more elegant way to accomplish this? (not even sure if this would work). Thanks. e

[Nile]

Thats exactly how I would do it, below are a few things.

• You're putting an at('@') sign before the mysql_query. I'd only put this there if this was a condition of an if statement.
• Why do you have two variable $querys in the die statement?

[kuau]

Dear Nile:

Thanks! Maybe I am finally starting to get the hang of php (miracle).

I have no idea what the "@" is for. I'm just a mimmick learning from doing what I see, with your help of course. Is it optional? I guess I should remove it. Does the result differ if it is there or not?

It is not 2 $query's. If it failed, it would say, "Couldn't execute 'SELECT * FROM table' query. The second is just a word.

Because I figured the last event_id is not an array and is only one thing, I since changed it to this:

$query = "SELECT LAST_INSERT_ID() FROM event ";
	$result = mysql_query($query,$connection) or die("Couldn't execute $query query. <br> mysql error: ".mysql_error()); 
	$neweventid = mysql_result($result,0,0);

Is this better or worse? Thanks, e

[Nile]

Ok, I see. But you should only use the @ when you're putting it as a condition in an if statement.

[kuau]

Why? What does @ mean?

[thetestingsite]

The @ symbol is simply an error suppression tool, and it's not the best way to get rid of error messages either. The better way is to use the error_reporting function like so:

<?php
error_reporting(0);

//rest of code here
?>

If the code is written properly, you shouldn't even need to use this, but there may be times where it may be needed.
Hope this helps.

[kuau]

I had no idea it had anything to do with error messages. It was just in the old code I inherited and it seemed to work, so I didn't question it. I WANT to see the error messages so I can fix things! Can I safely remove it from all my code using a search and replace, or could it break things?

Thanks, e

[thetestingsite]

If there are email addresses (or even anything that is important that has the @ symbol), it would mess those up. If you just removed it from the php code, you should be alright. Keep in mind; however, that you any errors that were suppressed will now pop up (if any).

Hope this helps.

[kuau]

I would do a search on "$result = @mysql_query($query,$connection)" because that is what I consistently used everywhere. Maybe I'll change a few manually and see what happens first. Thanks for the advice. Having witnessed this guy's sloppy coding practices, I can see why he used it everywhere. I would rather have the code correct than sweep junk under the carpet.

Niles, thanks for noticing that! I would have been doing that forever! e

[Nile]

I'm happy to help you Kuau.