despertly need help-getelement by id wont work

[genia]

function getWindowHeight() {
var windowHeight=0;
if (typeof(window.innerHeight)=='number') {
windowHeight=window.innerHeight;
}
else {
if (document.documentElement&&
document.documentElement.clientHeight) {
windowHeight=
document.documentElement.clientHeight;
}
else {
if (document.body&&document.body.clientHeight) {
windowHeight=document.body.clientHeight;
}
}
}
return windowHeight;
}
var t
t=getWindowHeight(this)
alert(t)
x=(t-400)
document.getElementById('row4r').style.padding-bottom=x+"px"

[Dal]

document.getElementById('row4r').style.padding-bottom=x+"px"

Is this the part that wont work?

[genia]

exactly
checked for case sensitivity and lots of things

[blm126]

Most likely, the page isn't loaded when you are trying to run that function. I need to see the whole page to be sure. But, if I'm right then try this code and see what happens

function getWindowHeight() {
var windowHeight=0;
if (typeof(window.innerHeight)=='number') {
windowHeight=window.innerHeight;
}
else {
if (document.documentElement&&
document.documentElement.clientHeight) {
windowHeight=
document.documentElement.clientHeight;
}
else {
if (document.body&&document.body.clientHeight) {
windowHeight=document.body.clientHeight;
}
}
}
return windowHeight;
}
window.onload = function(){
var t
t=getWindowHeight(this)
alert(t)
x=(t-400)
document.getElementById('row4r').style.padding-bottom=x+"px"
}

Just a note for the future, it is much easier to help if you format your code when posting.

[genia]

first of all thanks for helping.here is the full page-and it's not working

http://www.stargatemedia.co.il/abou_tt%20(2).htm

god its furstrating.

[jscheuer1]

This will never work:

document.getElementById('row4r').style.padding-bottom=x+"px"

It needs to be:

document.getElementById('row4r').style.paddingBottom=x+"px";

And, as mentioned already, document.getElementById('row4r') must already exist before this is executed, onload would be a good time because in IE, even the other dimensions you seek may not be available until that time anyway.

Another caveat, there must be only one element on the page with the row4r id.

[genia]

man,thank you very very very very very very much

[Dal]

Hehe well spotted jscheuer1

If they had there head screwed on when they named these DOM attributes they could have kept them the same for CSS and javascript then things like this would happed.

Dal

[genia]

exactly.
tell me something..now the function getWindowHeight gives me the height of the browser?
can i change it to give me the height of the viewing port? how?

document.getElementById("row4r").style.height=document.screen.availHeight-660+"px"

not quiet working...
thanks again guys for your help

[jscheuer1]

This generally works:

function set_row4r(){
var iecompattest = function(){
return (document.compatMode && document.compatMode!="BackCompat")? document.documentElement : document.body;
};

var wh = window.innerHeight? window.innerHeight : iecompattest().clientHeight;

document.getElementById("row4r").style.height = wh + 'px';
};
window.onload = set_row4r;

If you have other onload events, it would need to be integrated with them in one of the various ways available for that.