directory script

[insanemonkey]

I haveing some issues..

I have a directory script and it shows
.
..
before the files..

how do i get rid of it..

<?
include("../include/session.php");
?>

<?php
if (is_dir($dir)) {
    if ($dh = opendir($dir)) {
        while (($file = readdir($dh)) !== false) {

            echo "$file";
        }
        closedir($dh);
    }
}
?>

just need to get rid of
.
..

thanks

[boogyman]

../ indicates the file above the current directory.

if the include directory is underneath the document root or accessible to the web (http://mydomain.com) you have 2 options. you can use the absolute path (http://mydomain.com/folder/file)
or a relative absolute path (/folder/file)... the first forward slash is an indication to start at the document root.

if the include file is above the document root well it would be more tricky. because you need to edit some other scripts on your server. we can tackle that if this is the case... PS we would need the OS Type (Linux / Unix / Windows)

[insanemonkey]

I think its windows...

[Twey]

if (is_dir($dir))
  if ($dh = opendir($dir)) {
    while (($file = readdir($dh)) !== false)
      if (strpos($file, '.') !== 0)
        echo $file;
    closedir($dh);
  }
}

[djr33]

Though that's the most efficient in this case, you should learn to make a habit of including this line:
if ($f=='.'||$f== '..') { continue; }
(at that start of the loop)

[Twey]

The equivalent would be:

if (is_dir($dir))
  if ($dh = opendir($dir)) {
    while (($file = readdir($dh)) !== false) {
      if (strpos($file, '.') === 0) continue;
      echo $file;
    }
    closedir($dh);
  }

djr33, you even include braces when you neglect indentation? :-\

[djr33]

I don't feel like wasting space with indentation, as it's a simple and notable command-- skip . and .., not some complex if and reaction.
I don't like omitting brackets because it guides the eye-- if they aren't there, your eye may continue to find the close bracket (as the first, or, rather, lack thereof, may not be noticed when skimming because it sorta blends with the close ')').

By the way, I wasn't rebutting your reply, but just telling insanemonkey to use that. It's a good habit, unless you want to completely skip all directories.
In most cases, one wants to go through everything and of course skip the . and .. directories, but do something with files and do something else with directories; but skip the . and .. dirs. This will end with some weird errors, too, so it's just a basic part of the setup.

The exception, obviously, is if you just want to skip all directories; in that case, just use the above line.

[insanemonkey]

thankyou you forgot to put some '{' in there but i got it thankyou..

[Twey]

I don't feel like wasting space with indentation, as it's a simple and notable command-- skip . and .., not some complex if and reaction.

Fair.

I don't like omitting brackets because it guides the eye-- if they aren't there, your eye may continue to find the close bracket (as the first, or, rather, lack thereof, may not be noticed when skimming because it sorta blends with the close ')').

Not at all. The indentation (or lack thereof) shows clearly that the conditionally-executed block doesn't extend to the next line.

The exception, obviously, is if you just want to skip all directories; in that case, just use the above line.

What? My code, at least, had nothing to do with skipping all directories...

[djr33]

Huh?
if (strpos($file, '.') === 0) continue;
What else DOES that do?


As for indentation, that's fair enough, but I find the brackets still helpful if skimming quickly (as if to find a section of the code). When looking at each line, lack of brackets is fine.
Also, the real reason for including it is to be absolutely correct. I see omitting the brackets as a shortcut, just like omitting the ; in javascript. I prefer having these, just to be sure that's not the problem if/when debugging. If I'm writing quickly, I may omit them. (Or to minimize the characters in a code, if there's some reason.)