Write action without '

[lindm]

Is it possible anyway to write this html/javascript without the use of single hyphen? (' ')
Perhaps a separate javascript function? The 'writeform.php' is causing problems with a following php script...

<input  
 type="button" class="px10" 
 onclick="this.form.action='writeform.php'; this.form.submit();"  
 value="Import" 
>

[boogyman]

yes it is possible, but you would need to escape all of the double quotes with a backslash ( \ )

<input type=\"button\" class=\"px10\"
...
>

[Twey]

Which is one reason among several that you should always break out of PHP parsing mode when outputting HTML or any other sort of complex data.

[boogyman]

he's talking about parsing in javascript not php

[Twey]

No, s/he has a statement such as:

print '<input';
print ' type="button" class="px10"';
print ' onclick="this.form.action='writeform.php';'
print '  this.form.submit();"';
print ' value="Import"';
print '>';

... which isn't working because of the single quotes around 'writeform.php.' It would be better written as:

?>
<input  
 type="button" class="px10" 
 onclick="this.form.action='writeform.php'; this.form.submit();"  
 value="Import" 
>
<?php

It would be even better if you didn't use the Javascript at all: try a type="submit" input element:

<input
  type="submit"
  class="px10"
  name="action"
  value="Import"
>

... then check if($_REQUEST['action'] === 'Import') in the page to which it submits, perhaps calling writeform.php if necessary. That class="px10" also look as if you might have something like:

.px10 {
  width: 10px;
}

If that's so, don't a) use pixels to size elements containing text or b) use class names that describe their style. Class names should be semantic and refer to the elements that they style, e.g. "submit-button".

[lindm]

What I am doing is using a php that writes html code to a html file:

$stringData = 

' HTMLCODE ';

The single quotes breaks the $stringData variable...

Boogyman, do you mean like this?

<input  
 type=\"button\" class=\"px10\" 
 onclick=\"this.form.action=writeform.php; this.form.submit();\"  
 value=\"Import\" 
>

The px10 class is for the font size.

[Twey]

What I am doing is using a php that writes html code to a html file:

Well, you have two obvious options for readability, then: one is output buffers:

  ob_start();
?>
<input
  type="submit"
  class="px10"
  name="action"
  value="Import"
>
<?php
  $stringData = ob_get_clean();

and the other is the heredoc syntax:

$stringData = <<<EOF
<input
  type="submit"
  class="px10"
  name="action"
  value="Import"
>
EOF;

The former is often easier because the latter still parses variables and such in the value. Either way, you should still be performing this check server-side, not using Javascript.

[lindm]

Could I create a function without single quotes that then is called by the onclick? Have tried a bit but can't get it to work...

function submitformSIE()
{
  this.form.action="writeformsie.php";
  return true;
}

<input type="button" name="button2" id="button2" onclick="submitformSIE()" value="Button" />

[Twey]

Hey, are all my posts in this thread invisible?

1. You don't need and shouldn't use Javascript here.
2. Even if you did need to use Javascript, you don't need to and shouldn't be enclosing the whole thing with ugly quotes.

[djr33]

Twey's suggestions are good ones.

Using javascript when you don't need it is at best limiting some viewers on your page from submitting. It's also not secure.

Anyway, you can always escape quotes, in javascript, PHP, etc.

'Shouldn\'t be hard to do like this'
"or, \"Like this!\", I said..."

You can't simply write the javascript "without" the quotes, since that would cause random characters to be output which would be worthless to the browser (or even cause some strange reaction).
But you can, using the correct methods, display this using PHP.