Help creating a current link

[Twey]

No, he's right in this instance, I tried to write PHP4-compatible code but failed. Shame on me. The code for PHP4 is:

class Page {
  var $title;
  var $url;

  static $instances = array();

  static function get_current() {
    foreach(self::$instances as $page)
      if($page->url === SITE_URL . $_SERVER['REQUEST_URI'])
        return $page;
    return false;
  }

  function Page($title, $url) {
    $this->title = $title;
    $this->url = $url;
    Page::$instances[] = $this;
  }
}

define('SITE_URL', 'http://localhost/');

$pages = array(
  new Page('Home', SITE_URL),
  new Page('News', SITE_URL . '/news.php'),
  new Page('Forum', SITE_URL . '/forum')
);

$current_page = Page::get_current();

[matthewmjscott]

Sorry to be a huge pain but I am still getting the following error:

Parse error: syntax error, unexpected T_STATIC, expecting T_OLD_FUNCTION or T_FUNCTION or T_VAR or '}' in /home/bigbro/public_html/matthewmjscott/testingmenu.php on line 95

Line 95:

  static $instances = array();

There is no PHP code in there whatsoever apart from what I have used from this thread.

I'm a little clueless now

[Twey]

Ah, static variables in PHP4 are pretty much non-existant:

$page_instances = array();

class Page {
  var $title;
  var $url;

  static function get_current() {
    global $page_instances;

    foreach($page_instances as $page)
      if($page->url === SITE_URL . $_SERVER['REQUEST_URI'])
        return $page;
    return false;
  }

  function Page($title, $url) {
    global $page_instances;

    $this->title = $title;
    $this->url = $url;

    $page_instances[] = $this;
  }
}

define('SITE_URL', 'http://localhost/');

$pages = array(
  new Page('Home', SITE_URL),
  new Page('News', SITE_URL . '/news.php'),
  new Page('Forum', SITE_URL . '/forum')
);

$current_page = Page::get_current();

I hate PHP :-\

[matthewmjscott]

I hate PHP too, it's frustrating...

anyway, I'm now getting an error on line 97, which is this:

static function get_current() {

It's a static variable, which is what seems to be causing the problem... hopefully this should be the last time I need help?

I'm sorry for being a complete and utter pain!

[Twey]

Oh, yeah, missed that one:

$page_instances = array();

function page_get_current() {
  global $page_instances;

  foreach($page_instances as $page)
    if($page->url === SITE_URL . $_SERVER['REQUEST_URI'])
      return $page;
  return false;
}

class Page {
  var $title;
  var $url;

  function Page($title, $url) {
    global $page_instances;

    $this->title = $title;
    $this->url = $url;

    $page_instances[] = $this;
  }
}

define('SITE_URL', 'http://localhost/');

$pages = array(
  new Page('Home', SITE_URL),
  new Page('News', SITE_URL . '/news.php'),
  new Page('Forum', SITE_URL . '/forum')
);

$current_page = page_get_current();

Now, it should be noted that this is a Ruddy Ugly Hack©, of a magnitude of ugliness rarely seen in real, decent modern programming languages. In fact, even in PHP5 this isn't necessary, although that has plenty of problems of its own. I strongly suggest upgrading: support for PHP4 ends fairly soon, if I remember correctly. Moving to another language (Python? Ruby?) would be even better, of course

[matthewmjscott]

Oh my god thank you so much... you are totally awesome... thanks for helping me out when other people have turned me away!

This truly is the best coding forum in the world - I will be recommending it to all my friends!

And Twey, I will be working on upgrading/moving soon!

Thanks a million!

EDIT: Only problem is, the code you posted earlier on doesnt work:

<?php foreach($pages as $page) { ?>
<li><a href="<?php echo $page->url ?>"<?php if($page == $this_page) { ?> class="current"<?php } ?>><?php echo $page->title; ?></a></li>
<?php } ?>

It doesn't change the class to current on the selected tabs for some reason...

I should point out I need the ID of the <li> tags to be current and not the class of the links

[matthewmjscott]

Oh wait, fixed this problem myself.

$this_page

should be

$current_page

Thanks again!

[Twey]

Ah -- yes, my error.

[stroppy]

Hey

I came across this page whilst searching the web and just wanted to ask:

Is there any easy way to mod the script so that the class for one link could change to current for two or more URLs?

For example, I may want a "Home" button in the menu to change to a current class if the url read both http://www.example.com and http://www.example.com/index.php.

I hope I was clear enough? Sorry but I'm a total noob =(