Page 1 of 2 12 LastLast
Results 1 to 10 of 14

Thread: Some constructive criticism, please?

  1. #1
    Join Date
    Mar 2006
    Location
    Cleveland, Ohio
    Posts
    574
    Thanks
    6
    Thanked 5 Times in 5 Posts

    Default Some constructive criticism, please?

    http://www.alexjewell.com

    (password for the prompt is "al3x" - it's there until I'm fully done working on the site...I know it isn't very secure, but it's working for now)

    Let me know what you think about the design, the coding, anything. I want this to be a great site, and I want to know what you think. Thanks.
    Thou com'st in such a questionable shape
    Hamlet, Act 1, Scene 4

  2. #2
    Join Date
    May 2006
    Location
    Sydney, Australia - Near the coast.
    Posts
    1,995
    Thanks
    0
    Thanked 8 Times in 7 Posts

    Default

    Well... making the text white would be nice. I'm growing blind...

    Also, validate your page.
    Peter - alotofstuffhere[dot]com - Email Me - Donate via PayPal - Got spare hardware? Donate 'em to me :) Just send me a PM.
    Currently: enjoying the early holidays :)
    Read before posting: FAQ | What you CAN'T do with JavaScript | Form Rules | Thread Title Naming Guide

  3. #3
    Join Date
    Aug 2005
    Posts
    971
    Thanks
    0
    Thanked 0 Times in 0 Posts

    Default

    And what's up with the password? Anyone can find it out.

    Try this in firefox:

    Code:
    view-source:http://www.alexjewell.com/js/pshh.js

  4. #4
    Join Date
    May 2007
    Location
    USA
    Posts
    373
    Thanks
    2
    Thanked 4 Times in 4 Posts

    Default

    I don't like the use of the iframe in your design section. Just make it a part of the page, where the page itself scrolls instead of the frame.

    Also, if you don't know the password, you are stuck in an endless loop of prompts. I had to task manager to exit my browser.
    Trinithis

  5. #5
    Join Date
    Jul 2007
    Location
    California
    Posts
    177
    Thanks
    2
    Thanked 0 Times in 0 Posts

    Default

    I think the password is just there to lock out general people until it's public ready...ya?

  6. #6
    Join Date
    Mar 2006
    Location
    Cleveland, Ohio
    Posts
    574
    Thanks
    6
    Thanked 5 Times in 5 Posts

    Default

    The password really isn't meant to be secure, it's just a temporary block until I'm ready to "release" the site. It keeps looping until the right password is entered because that's the whole point, the content is supposed to be hidden until the password is entered. Any ideas on how to allow people to close the window if they don't know the password? Maybe a key they can hit to disable the prompt and refresh to an error page? Also, it will only be up for a little while longer - it was just a quick idea.

    Quote Originally Posted by tech_support View Post
    Well... making the text white would be nice. I'm growing blind...

    Also, validate your page.
    Haha, Tech. Maybe I'll add a little something just for you. We'll see.

    And the validation - the only thing that doesn't validate is a target="_blank" in a link...I'll probably replace it with a javascript function.

    Quote Originally Posted by Trinithis View Post
    I don't like the use of the iframe in your design section. Just make it a part of the page, where the page itself scrolls instead of the frame.
    The iframe is temporary. I plan on condensing my design site into this one, and when I do that I'll just make a portfolio within this site. Until then, I have the iframe. Trust me - it isn't my favorite part of the site, either, but oh well.

    Thanks guys for the comments/ideas.
    Thou com'st in such a questionable shape
    Hamlet, Act 1, Scene 4

  7. #7
    Join Date
    Jun 2005
    Location
    英国
    Posts
    11,876
    Thanks
    1
    Thanked 180 Times in 172 Posts
    Blog Entries
    2

    Default

    Any ideas on how to allow people to close the window if they don't know the password? Maybe a key they can hit to disable the prompt and refresh to an error page?
    That's what the cancel button is for. The prompt() function returns null on cancel:
    Code:
    var r;
    while((r = prompt("Password:")) !== "al3x")
      if(r === null)
        location.href = "http://www.google.com/";
    Twey | I understand English | 日本語が分かります | mi jimpe fi le jbobau | mi esperanton komprenas | je comprends français | entiendo español | tôi ít hiểu tiếng Việt | ich verstehe ein bisschen Deutsch | beware XHTML | common coding mistakes | tutorials | various stuff | argh PHP!

  8. #8
    Join Date
    Jan 2006
    Posts
    18
    Thanks
    0
    Thanked 0 Times in 0 Posts

    Default

    loose the black text on that dark putty green. It's too hard to read.

  9. #9
    Join Date
    Jun 2005
    Location
    英国
    Posts
    11,876
    Thanks
    1
    Thanked 180 Times in 172 Posts
    Blog Entries
    2

    Default

    Loose \Loose\ (l[=oo]s), v. n. [imp. & p. p. Loosed (l[=oo]st); p. pr. & vb. n. Loosing.] [From Loose, a.]
    1. To untie or unbind; to free from any fastening; to remove the shackles or fastenings of; to set free; to relieve.
    I suspect you probably meant "lose."
    Twey | I understand English | 日本語が分かります | mi jimpe fi le jbobau | mi esperanton komprenas | je comprends français | entiendo español | tôi ít hiểu tiếng Việt | ich verstehe ein bisschen Deutsch | beware XHTML | common coding mistakes | tutorials | various stuff | argh PHP!

  10. #10
    Join Date
    Jan 2006
    Posts
    18
    Thanks
    0
    Thanked 0 Times in 0 Posts

    Default

    yes... LOL

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •