does anyone see anything wrong with this code???

[kimberlyhello]

this code doesn't work:


if(document.signup.checkbox1.checked)
{document.signup.account1.disabled=false;}

if(document.signup.checkbox2.checked)
{document.signup.account1.disabled=false && document.signup.account2.disabled=false;}

if(document.signup.checkbox3.checked)
{document.signup.account1.disabled=false && document.signup.account2.disabled=false; && document.signup.account3.disabled=false;}

if(document.signup.checkbox4.checked)
{document.signup.account1.disabled=false && document.signup.account2.disabled=false && document.signup.account3.disabled=false && document.signup.account4.disabled=false;}

if(document.signup.checkbox5.checked)
{document.signup.account1.disabled=false && document.signup.account2.disabled=false && document.signup.account3.disabled=false && document.signup.account4.disabled=false && document.signup.account5.disabled=false;}

}

[tech_support]

Change && to ;

And don't assume form elements as properties of a document.
Always use: document.forms['formname'].elements['inputname'].disabled = false

[thetestingsite]

Adding on to the above post, the code would look like so:

if(document.forms["signup"].elements["checkbox1"].checked)
{document.forms["signup"].elements["account1"].disabled=false;}

if(document.forms["signup"].elements["checkbox2"].checked)
{ document.forms["signup"].elements["account1"].disabled=false;
   document.forms["signup"].elements["account2"].disabled=false;}

if(document.forms["signup"].elements["checkbox3"].checked)
{document.forms["signup"].elements["account1"].disabled=false; 
document.forms["signup"].elements["account2"].disabled=false;
document.forms["signup"].elements["account3"].disabled=false;}

if(document.forms["signup"].elements["checkbox4"].checked)
{document.forms["signup"].elements["account1"].disabled=false;
document.forms["signup"].elements["account2"].disabled=false;
document.forms["signup"].elements["account3"].disabled=false; 
document.forms["signup"].elements["account4"].disabled=false;}

if(document.forms["signup"].elements["checkbox5"].checked)
{document.forms["signup"].elements["account1"].disabled=false;
document.forms["signup"].elements["account2"].disabled=false;
document.forms["signup"].elements["account3"].disabled=false;
document.forms["signup"].elements["account4"].disabled=false;
document.forms["signup"].elements["account5"].disabled=false;
}

}

Hope this helps.

[Twey]

Or:

for(var i = 1, f = document.forms['signup'].elements, e; e = f['checkbox' + i]; ++i)
  if(e.checked)
    for(var j = 1, g; j <= i && g = f['account' + j]; ++j)
      g.disabled = false;

[mburt]

Thank-you, Twey. I really hate seeing repetitive code like that, when those great things called... LOOPS. Will work fine .

[kimberlyhello]

Thank you all for all the input. I really appreciate it.

So, the code given to me by thetestingsite works. But I tried the code posted by twey, and it did not work...not sure why.

I'm just glad it's working!

However, I still have a problem. Let's say a person clicks checkbox5, this enables all of the text fields. And then they change their mind and click on checkbox2. What happens is, all of the text fields are still enabled.

So basically, I want each checkbox to enable certain text fields, but if the checkbox is deselected, I want the text fields to be disabled again.

I hope this makes sense. I wrote a code that I thought might work...but of course it doesn't. Here it is:









{

if(document.forms["signup"].elements["checkbox1"].checked)
{document.forms["signup"].elements["account1"].disabled=false;}

else {document.forms["signup"].elements["account1"].disabled=true;}


if(document.forms["signup"].elements["checkbox2"].checked)
{ document.forms["signup"].elements["account1"].disabled=false;
document.forms["signup"].elements["account2"].disabled=false;}

else { document.forms["signup"].elements["account1"].disabled=true;
document.forms["signup"].elements["account2"].disabled=true;}


if(document.forms["signup"].elements["checkbox3"].checked)
{document.forms["signup"].elements["account1"].disabled=false;
document.forms["signup"].elements["account2"].disabled=false;
document.forms["signup"].elements["account3"].disabled=false;}

else {document.forms["signup"].elements["account1"].disabled=true;
document.forms["signup"].elements["account2"].disabled=true;
document.forms["signup"].elements["account3"].disabled=true;}


if(document.forms["signup"].elements["checkbox4"].checked)
{document.forms["signup"].elements["account1"].disabled=false;
document.forms["signup"].elements["account2"].disabled=false;
document.forms["signup"].elements["account3"].disabled=false;
document.forms["signup"].elements["account4"].disabled=false;}

else {document.forms["signup"].elements["account1"].disabled=true;
document.forms["signup"].elements["account2"].disabled=true;
document.forms["signup"].elements["account3"].disabled=true;
document.forms["signup"].elements["account4"].disabled=true;}


if(document.forms["signup"].elements["checkbox5"].checked)
{document.forms["signup"].elements["account1"].disabled=false;
document.forms["signup"].elements["account2"].disabled=false;
document.forms["signup"].elements["account3"].disabled=false;
document.forms["signup"].elements["account4"].disabled=false;
document.forms["signup"].elements["account5"].disabled=false;

else {document.forms["signup"].elements["account1"].disabled=true;
document.forms["signup"].elements["account2"].disabled=true;
document.forms["signup"].elements["account3"].disabled=true;
document.forms["signup"].elements["account4"].disabled=true;
document.forms["signup"].elements["account5"].disabled=true;
}


Thanks again,
Kim


ps. Can someone tell me what the best way to learn javascript is. Should I be reading a book???

[tech_support]

Can you give us a demo/HTML source of your page?

Should I be reading a book???

No. You can find all the information you need, from the internet. If you can't understand it/too complex it's ok to start of another thread here.

[Twey]

Please show us your live page, preferably using my code.

[mburt]

preferably using my code.

Which, by the way, will save you lots of time. As I've said, it's way more convenient, and used more practically.

[kimberlyhello]

I tried to use your code Twey, but I couldn't get it to work.

Here is the page:

http://www.spidersneeze.com/form/keyword.htm

The five radio buttons at the top are supposed to enable the 5 text fields below them.

The first radio button should enable text field 1
The second radio button should enable both text field 1 and 2
The third radio button should enable text fields 1,2, and 3
The fourth radio button should enable text fields 1,2,3, and 4
The fifth radio button should enable text fields 1,2,3,4, and 5.