URLS like: index.php?page=page1 ???

[mburt]

I have this on my index.php, and it won't work?

<?php
$page = $_GET[q];
$queries = array("home","scripts","resources","ie","guestbook","about","projects");
$results = array("index.php","scripts.php","resources.php","get_firefox.php","guestbook.php","about.php","projects.php");
for ($i = 0;$i < count($queries);$i++) {
	if ($page == $queries[$i]) {
		header("Location: $results[$i]");
		}
}
?>

and on my menu.php (which is embedded into my index.php using file_get_contents):

<ul>
<li><a href="?q=home" id="index">Home</a></li>
<li><a href="?q=scripts" id="scripts">Scripts</a></li>
<li><a href="?q=resources" id="resources">Resources</a></li>
<li><a href="?q=ie" id="get_firefox">Switch From IE</a></li>
<li><a href="?q=guestbook" id="contact">Guestbook</a></li>
<li><a href="?q=about" id="about">About</a></li>
<li><a href="?q=projects">Upcoming Projects</a></li>
</ul>
<div class="mheader" id="resources">Top 3 Resources</div>
<ul>
<li><a href="http://www.dynamicdrive.com/" target="_blank" title="Dynamic Drive">Dynamic Drive</a></li>
<li><a href="http://www.javascriptsource.com/" target="_blank" title="JavaScript Source">JavaScript Source</a></li>
<li><a href="http://www.scriptsearch.com/" target="_blank" title="Script Search">Script Search</a></li>
</ul>
<div class="mheader">Funpic</div>
<ul>
<li><a href="http://www.funpic.org/">Funpic.org</a></li>
<li><a href="http://www.funpic.org/forum/webhosting">Funpic Board</a></li>
</ul>

[djr33]

On first glance, looks good.
Give it a test.

Also, you fail to specify an else.

A good php script should always have a default value if someone is trying to hack around your settings, or if an old link points to something that is now invalid, or if the user makes a typo. Otherwise, weird things can happen.

I would suggest removing "index.php" from the arrary, and using:
else {header=index.php} (format properly, of course)

That way, anything that doesn't match will default to the home setting... be it "home", nothing (important as if you just type the page filename, it won't have a value for the get variable), or another non-matching string.

[mburt]

Try it. It's exactly what I put there:
http://mburt.mb.funpic.org/
Once you go to another page, it doesn't work...

[djr33]

That's nothing complex.

In your a tags, you use href="?q=....", and that is simply added to the current URL.

So... if you're on scripts.php, then... you get script.php?q=...

Just use <a href="index.php?q=...">

Or, perhaps, <a href="./?q=..."> which I think (but am not sure) would work the same way.

[mburt]

I just thought of that *knocks self on head. But still one problem. The "index.php?q=scripts" doesn't appear in the address bar.

[djr33]

huh?
how's that related?

[mburt]

Look at Twey's site or blm126's site. I'm pretty sure they use the same method, but when I do it, the page address appears in the address bar. Not the query

[Twey]

Actually, there's an easier way. If you specify a get variable without a value, it exists within PHP as an empty string, so you can do:

if(isset($_GET['guestbook']))

However, an URL like /guestbook is still better.

[mburt]

However, and URL like /guestbook is still better.

How would I be able to use such a URL?

[djr33]

Index page in /guestbook directory.
(Not php)