
Originally Posted by
Eclyps19
Yours is still very very buggy. None of the buttons say anything, when i mouse over the first google button it clears my text field, when i hit enter, it pulls up the first page (like the 'feeling lucky' button for google), overlapping text, etc. Does it look fine on your computer? What browser are you using? I'm using firefox.
That covers many of my criticisms, but there are a few more.
The document contains presentational markup, which is bad enough, but using a Strict document type makes it a little worse. Some of the form elements have duplicated name attribute values which is wrong: the name attribute there (though not on form controls, of course) is a poor man's id attribute and must be unique. There are style attributes everywhere (rather than placing the declarations in a style sheet), br elements are used for vertical separation rather than margins, and the length values are omitting their required units.
Code:
<INPUT type=reset value=" " ... onMouseover="javascript:form.reset()">
This is bad for a few reasons. The control should have a label (as Eclyps19 wrote), and the mouseover is stupid. Moreover, the "javascript:" portion is just a label and pointless, and the identifier, form, may not be in the scope chain. One should really use "this.form".
A final criticism is that where font sizes are set (or an attempt is made at it), the units are either in pixels or points. Neither is appropriate - particularly the latter, which is aimed at print media. Use percentages, with values no lower than around 85% of the browser default.
There are legal issues here, too. The name, Google, is a registered trademark, and GoogleHybrid is arguably an infringement upon that. Similarly, the Google logo will be copyrighted, and creating a derivative work is surely a violation of that protection. Finally, most search engines place terms on how their services may be used by third parties, and it's possible that you violate that. I strongly suggest that you seek permission, first, from all parties involved otherwise you might end up with a rather nasty cease-and-desist letter.
Mike
Bookmarks