Originally Posted by
http://validator.w3.org/check?uri=http://members.shaw.ca/allewell/
Sorry, I am unable to validate this document because on line 7, 9, 29 it contained one or more bytes that I cannot interpret as utf-8 (in other words, the bytes found are not valid values in the specified Character Encoding).
Oh dear.
Code:
<!doctype html public "-//w3c//dtd html 3.2//en">
Outdated.
Code:
<title></title>
...
<script language="Javascript">
<!-- begin
document.title="D o u g i n B C ™ • C o l l e c t i n g • V i n t a g e • M a g a z i n e s • v 1 . 1";
// end -->
</script>
Huh?
Code:
<script language="Javascript">
<!-- begin
language is deprecated for type; hiding script like that isn't necessary.
Code:
/*
Disable Right Click Script III- by Renigade (renigade@mediaone.net)
For full source code, visit http://www.dynamicdrive.com
*/
Pointless script, don't know why it's still on DD. Annoys genuine users and does nothing to stop people taking your content.
Code:
function stoperror(){
return true
}
window.onerror=stoperror
Argh. Don't hide errors from the users -- that way they'll have no idea why the button isn't doing anything. If they don't want to see errors, they'll set their browser up that way.
Code:
<meta http-equiv="imagetoolbar" content="no">
Causes memory leaks, according to jscheuer1. Haven't been able to find any references though -- you'll have to ask him.
Code:
<script language="JavaScript1.2">
<!-- begin
img1=new Image()
img1.src="../images/close.jpg"
img2=new Image()
img2.src="../images/closeup.jpg"
img3=new Image()
img3.src="../images/closedwn.jpg"
// end -->
</script>
Try:
Code:
<script type="text/javascript">
function preloadImages() {
if(typeof preloadImages.store === 'undefined') preloadImages.store = [];
for(var i = 0; i < arguments.length; ++i)
(preloadImages.store[preloadImages.store.length] = new Image()).src
= arguments[i];
}
preloadImages("close.jpg", "closeup.jpg", "closedwn.jpg");
</script>
Avoid globals wherever possible.
Code:
<script language="JavaScript1.2">
<!-- begin
function show(id){
if (document.all) {
document.all[id].style.visibility = 'visible';
self.defaultStatus='Done';
}
}
// -->
</script>
<script language="JavaScript1.2">
<!-- begin
function hide(id){
if (document.all) {
document.all[id].style.visibility = 'hidden';
}
}
// -->
</script>
Ych, IE-only.
Code:
<script type="text/javascript">
function show(id) {
var el = document.getElementById && document.getElementById(id) ?
document.getElementById(id) :
document.all && document.all[id] ?
document.all[id] :
document.images[id] || document.forms[id] || null;
if(!el) return false;
el.style.visibility = "visible";
return true;
}
function show(id) {
var el = document.getElementById && document.getElementById(id) ?
document.getElementById(id) :
document.all && document.all[id] ?
document.all[id] :
document.images[id] || document.forms[id] || null;
if(!el) return false;
el.style.visibility = "hidden";
return true;
}
</script>
Code:
<table border="0" height=100% width=100% cellspacing="0" cellpadding="0" style="position:absolute;visibility:hidden;height:100%;width:100%;background-color:transparent;cursor:default;z-index:10;">
Tables shouldn't be used for layout any more. We have CSS to do the job properly now. Also, using inline CSS so much defeats the point of using CSS at all.
Code:
<script language="JavaScript">
<!-- begin
if (screen.width==800||screen.height==600)
document.write("<img src='July-15-1905.jpg' height='350' width='265' border='0' title='July 15, 1905'>")
else
document.write("<img src='July-15-1905.jpg' height='450' width='341' border='0' title='July 15, 1905'>")
// end -->
</script>
Doesn't leave anything for non-JS browsers. Try:
Code:
<img id="varimg1" width="265" height="350" border="0" title="July 15, 1905">
<script type="text/javascript">
if (screen.width > 800 || screen.height > 600) {
var e;
(e = document.getElementById("varimg1").style).width = "341px";
e.height = "450px";
}
</script>
Font sizes should never be specified in pixels. Use percentages instead.
Code:
font-family:verdana;
Verdana is a bad choice for Web fonts, since it is larger than other fonts at the same point size. Also, you should specify a generic font family in case the user doesn't have the specific fonts you use.
Code:
<script language="JavaScript">
<!-- begin
if (screen.width==800||screen.height==600)
document.write("<span style='font-size:11;color:darkred;letter-spacing:2px;'>A collector of vintage magazines</span></br><img src='../images/dbcbanner.jpg' height='55' width='379' border='0'>")
else
document.write("<span style='font-size:13;color:darkred;letter-spacing:2px;'>A collector of vintage magazines</span></br><img src='../images/dbcbanner.jpg' height='60' width='468' border='0'>")
// end -->
</script>
This wouldn't be necessary if you used proportional font sizes. Also, you need to specify units:
The fishmonger's is 3 from your house. How long, on average, will it take you to get there by bus?
Code:
if (screen.width==640||screen.height==480)
document.write("<img src='fx.jpg' height='55' width='225' border='0' vspace='3' title='F.X. Leyendecker'>")
else if (screen.width==800||screen.height==600)
document.write("<a href='javascript:show(\"fx\");' onmouseover='window.status=\"Done\";return true' onmouseout='window.status=\"Done\";return true'><img src='fx.jpg' height='55' width='225' border='0' vspace='3' title='F.X. Leyendecker'></a>")
else
document.write("<a href='javascript:show(\"fx\");' onmouseover='window.status=\"Done\";return true' onmouseout='window.status=\"Done\";return true'><img src='fx.jpg' height='55' width='225' border='0' vspace='3' title='F.X. Leyendecker'></a>")
That looks like another kludged attempt to compensate for absolute sizing. Also, the mouseover and mouseout events suggest you're trying to hide the URLs those links point to. Don't bother. It won't work.
Junior Coders
New Website
My general approach to writing code is to sit down at a text editor and type the whole thing, then start debugging. When it's a fragment, I fear I neglect that last step all too often
Posting Permissions
Reply With Quote
Bookmarks