[DHTML] Cmotion Major Upgrade

[ratkinsonuk]

There is a bug in the current code, and can be seen on http://www.dynamicdrive.com/dynamici...iongallery.htm

"Line 168 - Invaild Argument"

Which is - cross_scroll.style.left=(menuwidth-actualwidth)/startpos+'px';

Rob.

[Twey]

In which browser? Which version? What were you doing when the error appeared?

[jscheuer1]

In which browser? Which version? What were you doing when the error appeared?

I think I see it, in FF it is reported as:

Error: Error in parsing value for property 'left'. Declaration dropped.
Source File: http://www.dynamicdrive.com/dynamici...iongallery.htm
Line: 0

and I get it in IE as line 169. But, since it only happens onresize, it must be that line (red) from the function:

onresize=function(){
if (typeof motioncontainer!=='undefined'&&motioncontainer.filters){
motioncontainer.style.width="0";
motioncontainer.style.width="";
motioncontainer.style.width=Math.min(motioncontainer.offsetWidth, maxwidth)+'px';
}
menuwidth=crossmain.offsetWidth;
cross_scroll.style.left=(menuwidth-actualwidth)/startpos+'px';
}

which just happens to be line# 168 in motiongallery.js. I think it comes from dividing by zero which, in this case, produces negative infinity. The error disappears if 'startpos' is other than 0 in the configuration. So, you can make that line be:

cross_scroll.style.left=startpos? (menuwidth-actualwidth)/startpos+'px' : 0;

If that does in fact take care of the problem (should) and causes no new error(s), I would recommend that the demo page be updated with this fix.

Added Later: Seems to do the trick!

[ddadmin]

Great, thanks John. Script on DD updated with this little fix as well.

[chewbacka]

I'm trying to change the width of the main gallery/div. I've looked around the motiongallery.js and have had no luck. I did not changing anything within motiongallery.js. Can some one please help me. Thanx in advance

[jscheuer1]

As this script is now available in the Dynamic Drive scripts library:

http://www.dynamicdrive.com/dynamici...iongallery.htm

It would be better to post a question of this nature in the main Dynamic Drive Scripts Help forum.

The dimensions of the gallery are set in the gallerystyle.css file. If you need more help, please use the main help forum.

[3bood]

i need to put an image above the scropt but i cant do .. can u help me ??

[jscheuer1]

i need to put an image above the scropt but i cant do .. can u help me ??

Please use the main Dynamic Drive Scripts Help forum:

http://www.dynamicdrive.com/forums/forumdisplay.php?f=2

[sabodj]

This works great in IE, however when I hover over the images in FF the border disappears and the image flickers.

[jscheuer1]

This works great in IE, however when I hover over the images in FF the border disappears and the image flickers.

Does this happen on the demo page? If not, it is a problem with your implementation and it would be better to post a new thread in the main help section:

http://www.dynamicdrive.com/forums/forumdisplay.php?f=2