Check this script??? I know its Bad.

[Twey]

Oh, I see... it looks as though you've copied and pasted the script from somewhere and missed a big chunk off the top.

[jad9321]

Not quite,
I wrote it by looking at another script. Some of it was changed, All i want it to do is ask for the db username, Password, And DB and create the tabel.

[jad9321]

Twey you have any ideaaa on how to fix this???

[jr_yeo]

where is the if part for the

}else{ $muser = $_POST['muser']; $mpass = $_POST['mpass']; $mdata = $_POST['mdata'] 

if it exist before the <form></form> script then u should

</form><? } else { 
// the rest of the code here
?>

i think....

[jad9321]

Dont see it...

[jr_yeo]

what dont u see?

the if part for the else clause or what m referring to?

[jad9321]

I dont see

</form><? } else {  
// the rest of the code here 
?>

And the if part... Is the if part this?:

if(empty($muser) || empty($mpass) || empty($mdata)){
      Echo"<b>Error:</b> You have some boxes with No info in them, You MUST fill in EVERY BOX!";
      die();
    }

[jr_yeo]

the script should like something like :

<?if (condition) { ?>
<form method='post' action='install.php?step=1'>
    <table>
    <tr>
      <td>MySQL User:</td>
      <td><input type='text' name='muser' size='20'></td>
    </tr>
    <tr>
      <td>MySQL Password:</td>
      <td><input type='text' name='mpass' size='20'></td>
    </tr>
    <tr>
      <td>MySQL Database:</td>
      <td><input type='text' name='mdata' size='20'></td>
    </tr>
    <tr>
   
     <td>Make sure all the above info is correct.</td>
       
      <td><input type='submit' name='submit' value='Submit'></td>
    </tr>
    </table>
    </form><?
     }else{
    $muser = $_POST['muser']; $mpass = $_POST['mpass'];
    $mdata = $_POST['mdata']; 
    }
    if(empty($muser) || empty($mpass) || empty($mdata) ||{
      Echo"<b>Error:</b> You have some boxes with No info in them, You MUST fill in EVERY BOX!";
      die();
    }

// Connect to Check
    mysql_connect ("localhost", "$muser", "$mpass") or die(mysql_error());
    mysql_select_db ("$mdata");

    // Create Tables

mysql_query("CREATE TABLE `request` (
      `Habbo Name` varchar(20) NOT NULL default '',
      `Song Request` varchar(50) NOT NULL default '',
      `Shoutout\Joke` varchar(10) NOT NULL default '',
      PRIMARY KEY  (`Habbo Name`)
    ) TYPE=MyISAM") or die(mysql_error()); ?>

dunno how to highlight the correction(s) that i think should be corrected? (redundant huh?)

[jad9321]

And what should the condition be, cause i'm stupid...

[jr_yeo]

if that is the case, that if part should be before the else part