Check this script??? I know its Bad.

**jad9321** · 07-07-2006, 04:49 PM

Hey guys... I just through a script together really quick. can you check it out... Dosent seem to work...

Code:

    <form method='post' action='install.php?step=1'>
    <table>
    <tr>
      <td>MySQL User:</td>
      <td><input type='text' name='muser' size='20'></td>
    </tr>
    <tr>
      <td>MySQL Password:</td>
      <td><input type='text' name='mpass' size='20'></td>
    </tr>
    <tr>
      <td>MySQL Database:</td>
      <td><input type='text' name='mdata' size='20'></td>
    </tr>
    <tr>
   
     <td>Make sure all the above info is correct.</td>
       
      <td><input type='submit' name='submit' value='Submit'></td>
    </tr>
    </table>
    </form>";

    

     }else{
    $muser = $_POST['muser']; $mpass = $_POST['mpass'];
    $mdata = $_POST['mdata']; 
    
    if(empty($muser) || empty($mpass) || empty($mdata) ||{
      Echo"<b>Error:</b> You have some boxes with No info in them, You MUST fill in EVERY BOX!";
      die();
    }

// Connect to Check
    mysql_connect ("localhost", "$muser", "$mpass") or die(mysql_error());
    mysql_select_db ("$mdata");

    // Create Tables

mysql_query("CREATE TABLE `request` (
      `Habbo Name` varchar(20) NOT NULL default '',
      `Song Request` varchar(50) NOT NULL default '',
      `Shoutout\Joke` varchar(10) NOT NULL default '',
      PRIMARY KEY  (`Habbo Name`)
    ) TYPE=MyISAM") or die(mysql_error());

I know its really bad but i need help... :]

Demo at http://smileyoureahabbo.freepgs.com/install.php

**Twey** · 07-07-2006, 04:54 PM

Code:

    if(empty($muser) || empty($mpass) || empty($mdata) ||{

Forgot to close the condition.

**jad9321** · 07-07-2006, 04:57 PM

err??? How Do You Do That... lol i'm dumb.

**Twey** · 07-07-2006, 05:00 PM

Indubitably.

Code:

    if(empty($muser) || empty($mpass) || empty($mdata)){

**jad9321** · 07-07-2006, 05:06 PM

Its still not working...

Code:

    <form method='post' action='install.php?step=1'>
    <table>
    <tr>
      <td>MySQL User:</td>
      <td><input type='text' name='muser' size='20'></td>
    </tr>
    <tr>
      <td>MySQL Password:</td>
      <td><input type='text' name='mpass' size='20'></td>
    </tr>
    <tr>
      <td>MySQL Database:</td>
      <td><input type='text' name='mdata' size='20'></td>
    </tr>
    <tr>
   
     <td>Make sure all the above info is correct.</td>
       
      <td><input type='submit' name='submit' value='Submit'></td>
    </tr>
    </table>
    </form>";

    

     }else{
    $muser = $_POST['muser']; $mpass = $_POST['mpass'];
    $mdata = $_POST['mdata']; 
    
    if(empty($muser) || empty($mpass) || empty($mdata)){
      Echo"<b>Error:</b> You have some boxes with No info in them, You MUST fill in EVERY BOX!";
      die();
    }

// Connect to Check
    mysql_connect ("localhost", "$muser", "$mpass") or die(mysql_error());
    mysql_select_db ("$mdata");

    // Create Tables

mysql_query("CREATE TABLE `request` (
      `Habbo Name` varchar(20) NOT NULL default '',
      `Song Request` varchar(50) NOT NULL default '',
      `Shoutout\Joke` varchar(10) NOT NULL default '',
      PRIMARY KEY  (`Habbo Name`)
    ) TYPE=MyISAM") or die(mysql_error());

demo: http://smileyoureahabbo.freepgs.com/install.php

**jad9321** · 07-07-2006, 05:14 PM

hmm....

**Twey** · 07-07-2006, 05:18 PM

Can you give us the error(s) you get?

**jad9321** · 07-07-2006, 05:20 PM

It shows the accual text thats in the file on the page:

Code:

"; }else{ $muser = $_POST['muser']; $mpass = $_POST['mpass']; $mdata = $_POST['mdata']; if(empty($muser) || empty($mpass) || empty($mdata)){ Echo"Error: You have some boxes with No info in them, You MUST fill in EVERY BOX!"; die(); } // Connect to Check mysql_connect ("localhost", "$muser", "$mpass") or die(mysql_error()); mysql_select_db ("$mdata"); // Create Tables mysql_query("CREATE TABLE `request` ( `Habbo Name` varchar(20) NOT NULL default '', `Song Request` varchar(50) NOT NULL default '', `Shoutout\Joke` varchar(10) NOT NULL default '', PRIMARY KEY (`Habbo Name`) ) TYPE=MyISAM") or die(mysql_error());

You can see what I meen at http://smileyoureahabbo.freepgs.com/install.php