Javascript for select box help

[stompkins]

Hi all,
What I am trying to do is when the user uses the select box and slecects the option of Add/Delete it pops up a div.

As you can see in the code it works. What is bothering me is that when I select a regular option (i.e Architectural or Mechanical) it produces a javascript error. Can any one help me out so it does not show this error?

** note I am only seeing it say it has an error in IE**

sample of what I am doing is located here

http://www.stevetompkins.com/dropdown.html

Thanks in advance

[Twey]

Move the code in the <select>'s onchange event to the <option>'s onclick event.

[stompkins]

so you are saying take

onchange="hideAll(); changeDiv(this.options[this.selectedIndex].value,'block');"

and change it to

onclick="hideAll(); changeDiv(this.options[this.selectedIndex].value,'block');"

and move it from the select tag down to the option tag?

I tried that with no success =(

[Twey]

You haven't done it on your demo page.

[stompkins]

sorry about that I just made the change local. if you visit it now it is updarted with your suggestion.

Thanks

[Twey]

Revert your code, and let's just add some basic sanity checking:

function changeDiv(the_div,the_change)
{
  if(!document.getElementById(the_div)) return;
  document.getElementById(the_div).style.display=the_change;
}

[stompkins]

Awesome! I think that did the trick. I really appreciatet your help.

Thanks!

[djr33]

Just to let you know... that doesn't work in Safari. I'm not too surprised, though. It's JS implementation is different than FF/IE.

Also, I'd recommend having a "Choose one below" or something as the first item in the select menu, so that you don't have Architectural already up, but no div, causing confusion.

EDIT: Um.... this doesn't seem to work in FF either.
...or IE (5/mac).

[Twey]

Basically, doesn't work?

It's JS implementation is different than FF/IE.

It uses KHTML, insofar as I'm aware, so it's most similar to Konqueror. However, it tends to be several versions of the component behind Konqueror.

[djr33]

Well, I'm not talking about html. The html doesn't behave that differently... not in a noticably bad way, really.
The javascript just varies from other browsers.
Perhaps the javascript is part of the implemenation of KHTML; I wouldn't know.