Php... Help Please

Okay, I'm brand new to PHP and I'm doing pro-bono work for a friend, and I need help BADLY.

Everything works EXCEPT the submit button.

I just want this form to be emailed to an email address.

Please help me!

*NOTE: It said the text I entered was too long, so if you can help me, please pm me your email so I can email everything to you.*

Thanks!

You can find a prebuilt e-mail form easily.

heres one I found, its free. http://www.maianscriptworld.co.uk/scripts_mail.html

Code:

<form action = "process.php" method="post"> ... </form>

process.php

PHP Code:

$to = "email@url.com"; $subject = "subject of email"; $from = trim(htmlspecialchars($_POST['email'])); $message = ""; // Populates the Message Body to be sent foreach($_POST as $key => $value) { $message .= trim(htmlspecialchars($key . " - " . $value) . " "); } // Try To Send Email if(!mail($to, $subject, $message, "From: $from")) { // If failure of send email - print error print "Cannot send email"; else { print "Email Sent! Thanks"; }

// EDIT

Quote:

*NOTE: It said the text I entered was too long, so if you can help me, please pm me your email so I can email everything to you.*

use the [c.ode][/c.ode] tags (without period) to wrap your text and you wont have to worry about text length

Thanks, here's the code

Code:

<?php # Script 3.13 - register.php if (isset($_POST['submit'])) { // Handle the form. $message = NULL; // Create an empty new variable. // Check for a name. if (strlen($_POST['CustomerName']) > 0) { $name = TRUE; } else { $name = FALSE; $message .= 'You forgot to enter your name!'; } // Check for an email address. if (strlen($_POST['EmailAddress']) > 0) { $email = TRUE; } else { $email = FALSE; $message .= 'You forgot to enter your email address!'; } // Check for an address. if (strlen($_POST['Address']) > 0) { $username = TRUE; } else { $username = FALSE; $message .= 'You forgot to enter your Address!'; } // Check for a City. if (strlen($_POST['City']) > 0) { $username = TRUE; } else { $username = FALSE; $message .= 'You forgot to enter your City!'; } // Check for an State. if (strlen($_POST['State']) > 0) { $username = TRUE; } else { $username = FALSE; $message .= 'You forgot to enter your State!'; } // Check for an ZipCode. if (strlen($_POST['ZipCode']) > 0) { $username = TRUE; } else { $username = FALSE; $message .= 'You forgot to enter your Zip Code!'; } // Check for an Phone Number. if (strlen($_POST['PhoneNumber']) > 0) { $username = TRUE; } else { $username = FALSE; $message .= 'You forgot to enter your Phone Number!'; } // Check for an Fax Number. if (strlen($_POST['FaxNumber']) > 0) { $username = TRUE; } else { $username = FALSE; $message .= 'You forgot to enter your Fax Number!'; } // Check for an Website. if (strlen($_POST['Website']) > 0) { $username = TRUE; } else { $username = FALSE; $message .= 'You forgot to enter your Website!'; } // Check for a First Design. if (strlen($_POST['FirstDesign']) > 0) { $username = TRUE; } else { $username = FALSE; $message .= 'You forgot to enter your Design!'; } // Check for a First Quantity. if (strlen($_POST['FirstQuantity']) > 0) { $username = TRUE; } else { $username = FALSE; $message .= 'You forgot to enter your Quantity!'; } // Check for a Phone Number. if (strlen($_POST['FirstPhone']) > 0) { $username = TRUE; } else { $username = FALSE; $message .= 'You forgot to enter the Phone Number to appear on your cards!'; } // Check for a Stock Color. if (strlen($_POST['FirstColor']) > 0) { $username = TRUE; } else { $username = FALSE; $message .= 'You forgot to enter the color of your cards! If Design 7 enter, White!'; } // Check for a Card Type. if (strlen($_POST['CardType']) > 0) { $username = TRUE; } else { $username = FALSE; $message .= 'You forgot to enter the type of Card you are using!'; } // Check for a Card Number. if (strlen($_POST['CardNumber']) > 0) { $username = TRUE; } else { $username = FALSE; $message .= 'You forgot to enter the Number on your Card!'; } // Check for a Card Name. if (strlen($_POST['CardName']) > 0) { $username = TRUE; } else { $username = FALSE; $message .= 'You forgot to enter the Name that Appeard on your card!'; } // Check for a Expiration Date. if (strlen($_POST['Expiration']) > 0) { $username = TRUE; } else { $username = FALSE; $message .= 'You forgot to enter the Expiration Date!'; } // Check for a Comments. if (strlen($_POST['Comments']) > 0) { $username = TRUE; } else { $username = FALSE; $message .= 'You forgot to enter your comments! If you have none, please just place "none" in the box!'; } if ($CustomerName && $EmailAddress && $Address && $City && $State && $ZipCode && $PhoneNumber && $FaxNumber && $Website && $FirstDesign && $FirstQuantity && $FirstPhone && $FirstColor && $CardType && $CardNumber && $CardName && $Expiration && $Comments) { // If everything's okay. // Register the user. // Send an email. $body = "Thank you for your order!\nYou will be receiving an email confirmation of your order very soon. The email you will receive this confirmation at is '{$_POST['EmailAddress']}'.\n\nSincerely,\nJennifer Greeney"; mail ($_POST['email'], 'Order Confirmation!', $body, 'From: jennifer.greeney@proforma.com'); header ('Location: thankyou.php'); exit(); } else { $message .= 'Please try again.'; } } // Set the page title and include the HTML header. $page_title = 'Order Form'; include ('./header.inc'); // Print the error message if there is one. if (isset($message)) { echo '', $message, ''; } ?> <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post"> <fieldset> <div align="center"> <legend>Enter your information in the form below:</legend> </div> <div align="center"><center> <table width="544" cellspacing="6" background="fadedbackground.jpg" bgcolor="#F2F2F2"> <tr> <td align="right" width="176">*Your name:</td> <td width="344"> <input class="inputc" size="29" name="CustomerName"> </td> </tr> <tr> <td align="right" width="176">* Your email address:</td> <td align="left" width="344"> <input class="inputc" size="29" name="EmailAddress"> </td> </tr> <tr align="middle"> <td align="right" width="176">* Mailing/Ship To Address:</td> <td width="344" align="left"> <input class="inputc" size="29" name="Address"> </td> </tr> <tr align="middle"> <td align="right" width="176">* City</td> <td width="344" align="left"> <input class="inputc" size="29" name="City"> </td> </tr> <tr align="middle"> <td align="right" width="176">* State:</td> <td width="344" align="left"> <input class="inputc" size="29" name="State"> </td> </tr> <tr align="middle"> <td align="right" width="176">* Zip Code:</td> <td width="344" align="left"> <input class="inputc" size="29" name="ZipCode"> </td> </tr> <tr align="middle"> <td align="right" width="176">* Phone Number:</td> <td width="344" align="left"> <input class="inputc" size="29" name="PhoneNumber"> </td> </tr> <tr align="middle"> <td align="right" width="176">* Fax Number:</td> <td width="344" align="left"> <input class="inputc" size="29" name="FaxNumber"> </td> </tr> <tr align="middle"> <td align="right" width="176">* Website:</td> <td width="344" align="left"> <input class="inputc" size="29" name="Website"> </td> </tr>

I had to create it in two parts:

Code:

<tr align="middle"> <td align="right" width="176"> </td> <td width="344" align="left">ORDER YOUR CARDS BELOW</td> </tr> <tr> <td align="right" width="176">* Design of Card:</td> <td width="344"> <input class="inputc" size="29" name="FirstDesign"> (For Reference Click <a href="www.scottandjudith.com/carddesigns.html" target="_blank">Here</a>)</td> </tr> <tr> <td align="right" width="176">* Quantity:</td> <td width="344"> <input class="inputc" size="29" name="FirstQuantity"> </td> </tr> <tr> <td align="right" width="176">* Phone Number to Appear on Card: </td> <td width="344"> <input class="inputc" size="29" name="FirstPhone"> </td> </tr> <tr> <td align="right" width="176">* Color of Card: </td> <td width="344"> <input class="inputc" size="29" name="FirstColor"> </td> </tr> <tr> <td align="right" width="176">Important information on order more than one design:</td> <td width="344">*If additional cards are desired enter them in the comments section before you submit your order. Enter the Design Number, Quantity, Card Color and Phone Number. A Order Confirmation will be sent to the email address you've provided above, please make sure it is valid. Thank you.</td> </tr> <tr> <td align="right" width="176"> </td> <td width="344">PAYMENT INFORMATION:</td> </tr> <tr> <td align="right" width="176">* Card Type:</td> <td width="344"> <input class="inputc" size="29" name="CardType"> (abbreviations accepted)</td> </tr> <tr> <td align="right" width="176">* Card Number:</td> <td width="344"> <input class="inputc" size="29" name="CardNumber"> </td> </tr> <tr> <td align="right" width="176">* Name on Card:</td> <td width="344"> <input class="inputc" size="29" name="CardName"> </td> </tr> <tr> <td align="right" width="176">* Expiration Date:</td> <td width="344"> <input class="inputc" size="29" name="Expiration"> (Format: 01/2008)</td> </tr> <tr> <td align="right" width="176"> </td> <td width="344">COMMENTS OR ADDITIONAL CARDS:</td> </tr> <tr> <td align="right" width="176">  * Your comments:</td> <td width="344"> <textarea style="FONT-SIZE: 10pt" name="Comments" rows="7" cols="40"></textarea> </td> </tr> <tr> <td width="176"> </td> <td width="344"> You must fill in the fields marked with a *</td> </tr> </table> </center></div> </fieldset> <div align="center"><input type="submit" name="submit" value="Submit Information" /></div> </form> <?php include ('./footer.inc'); // Include the HTML footer. ?>

Um,at a quick glance it looks like you copy and pasted the if/else statement block, but forgot to change $username to the correct variable.
So, when the code got to the final if, the undefined variables evaluated to false. You can prevent mistakes like this setting your error reporting level to E_ALL(check the manual for details)

I cannot believe I over looked that.

I went back and changed everything to the correct statements and now it's throwing this

Warning: mail() [function.mail]: SMTP server response: 501 unacceptable mail address in D:\Inetpub\wwwroot\nt04\jamestranstech.com\register1.php on line 156

Code:

mail ($_POST['EmailAddress'], 'Order Confirmation!', $body, 'From: jennifer.greeney@sbcglobal.net');

Warning: Cannot modify header information - headers already sent by (output started at D:\Inetpub\wwwroot\nt04\jamestranstech.com\register1.php:156) in D:\Inetpub\wwwroot\nt04\jamestranstech.com\register1.php on line 158

Code:

header ('Location: thankyou.php'); exit(); } else { $message .= 'Please try again.'; } } // Set the page title and include the HTML header. $page_title = 'Order Form'; include ('./header.inc'); // Print the error message if there is one. if (isset($message)) { echo '', $message, ''; }

Any suggestions?

Headers are sent out before any html or other text on the page.

All headers must be sent at the top of your script before ANYTHING else is output. Any echo commands or any html blocks outside of the PHP must be after that and only after that.

I thought so in reading about PHP but I cannot figure out where exactly to put it. Again I'm totally new to PHP.

Any suggestions on where I should place the header?

Any help is appreciated.

Before everything else that might output any html, etc. Simple as that. You may need to reorder some stuff or do something complex, but simply put, you MUST have it before any output.

As for the mail issue, the answer must be that $_POST['EmailAddress'] is not set correctly. Use a line of "echo $_POST['EmailAddress'];", to check if that was set. (Remove this for the final script, obviously.)

When I tried the echo statement it threw this error and wouldn't even open the page,

Quote:

Parse error: parse error, unexpected T_ECHO in D:\Inetpub\wwwroot\nt04\jamestranstech.com\register1.php on line 156

Also, if you will take a second and help scan over the beginning of the code, isn't the header before anything that outputs html?

Like I said, I'm new, so thanks for bearing with me.

The book I'm ready said to move the entire Isset () conditional to the very top of the page above the if (isset($_POST['submit'])) and I did that and now it only directs me to thankyou.php when I am at the page.

To see what I'm talking about go to www.jamestranstech.com/register1.php

:(

can anyone help me??

Hmm, djr33 is right about the headers. What's puzzling me is I don't see anything actually being echoed before that?

And...that isn't good. The solution for the redirection at the right time is to move the actual script to a different page and have the form submit to that different page. Make sense?

The other thing I was wondering, even though a bit off topic, is how secure you're making this? Any encryption/secure server? People aren't going to want to send their credit card info online if there's no security, and for good reason.

Looks like there isn't actually anything echoed first. I was looking at the small bit of code you posted last, which seemed to imply there may have been html before that. Looking back over all of it, I don't see any conflicts there.

However, this is still worth considering in that you have a confirmation message "...confirmation email sent to [email]." but it doesn't ever get displayed if you just redirect with a location header after that.

The unexpected T_ECHO is an error basically meaning that something in the syntax is off. It could be a missing semicolon (likely), open brackets/parentheses, two lines run together, etc.
Take a close look at that line and the one before it and the one after it. If you can't find the error, post those three lines. (Very likely it's right around the problem area, so we probably don't need the whole script.)

Cannot modify header information - headers already sent by (output started at D:\Inetpub\wwwroot\nt04\jamestranstech.com\register1.php:156) in D:\Inetpub\wwwroot\nt04\jamestranstech.com\register1.php on line 158

I dunno if it work or not but I always got that error, sometimes it's just that your page after submitted form have spaces... make sure there's no space in between php code and html... it worth it to try...

<?php echo "sample php code";?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">