header problem

Printable View

12-13-2006, 11:57 AM
munkynpunky

header problem

Hi guys,

I think my script is right but my host say its wrong...

can you find an issue?

PHP Code:

$URL='QUERY_STRING'; The query string is: <?php echo $_SERVER[$url]; ?> Filename: <? echo $_GET['filename'] ?> $url="www.en4cer.co.uk/downloads/".$url header ("Location: $URL"); <html> <title>Ades Design</title> <head></head> <body> </body> </html>
12-13-2006, 01:15 PM
Twey

I can find several.

Quote:

$URL='QUERY_STRING';

This code is outside a PHP block, so will be printed, not executed. Also, setting it to the static value 'QUERY_STRING' seems useless to me. I would suspect that you meant $_SERVER['QUERY_STRING'].

Quote:

The query string is: <?php echo $_SERVER[$url]; ?>

Variable names are case-sensitive. You defined $URL, not $url. The paragraphs are also outside an HTML body.

Quote:

Filename: <? echo $_GET['filename'] ?>

You haven't actually done anything with this, but it sounds dangerous, since it implies that you're going to allow the client to pass you a filename without doing any validation on it.

Quote:

$url="www.en4cer.co.uk/downloads/".$url

Here you define $url, but since $url currently isn't defined, $url is 'www.en4cer.co.uk/downloads/'. Since it's to be passed as a header, this should be a full URL, including protocol. Also, you missed a semicolon.

Quote:

header ("Location: $URL");

Equivalent to:

Code:

header ('Location: QUERY_STRING');

Quote:

<html>
<title>Ades Design</title>
<head></head>
<body>
</body>
</html>

No DOCTYPE was provided, the title should be inside the head, and you're still in PHP parsing mode. Also, this code will never (or should never) be read. I suppose it's not a bad idea to provide something for unusual clients, though, even if those clients don't support HTTP fully.

Code:

<?php $url = 'http://www.en4cer.co.uk/downloads/' . $_SERVER['QUERY_STRING']; header("Location: $url"); ?> <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd"> <html> <head> <title>Ades Design</title> </head> <body> Warning: your browser does not support HTTP correctly. It is likely that a large portion of the Web will be broken for you. You should have been sent to <a href="<?php print $url; ?>"><?php print $url; ?></a>. </body> </html>
12-13-2006, 01:35 PM
munkynpunky

ah, hang on....

Ok, the script is

PHP Code:

<? $URL='QUERY_STRING'; The query string is: <?php echo $_SERVER[$url]; ?> Filename: <? echo $_GET['filename'] ?> $url="www.en4cer.co.uk/downloads/".$url header ("Location: $URL"); ?>

<html>
<title>Ades Design</title>
<head></head>
<body>
</body>
</html>

this document is called downloads.php, and i go to downloads.php?file=8
12-13-2006, 01:43 PM
Twey

It's still wrong. Use the one I posted above.

Quote:

header ("Location: $URL");

I forgot to mention that this won't work, since you've already sent output.
12-13-2006, 02:21 PM
munkynpunky

Created a new document using your template above, but it doesnt work.. http://www.en4cer.co.uk/downloads2.php?file=8
12-13-2006, 02:31 PM
Twey

It was a complete script, not a template. Nevertheless, are you certain there was no whitespace before the opening <?php? If there were, the script would fail to work.
12-13-2006, 02:32 PM
mwinter

Quote:

Originally Posted by Twey

I suppose it's not a bad idea to provide something for unusual clients, though, even if those clients don't support HTTP fully.

There are some lingering HTTP/1.0 user agents, so yes, the HTTP/1.1 recommendations should be followed and certain redirections should be accompanied by a hypertext link. It's not that difficult: the markup you posted could be included in an include file. However, one should avoid mentioning technical details - especially when what you've written isn't necessarily correct :) - and just request that the user follow the link.

Mike
12-13-2006, 02:37 PM
munkynpunky

Quote:

Originally Posted by Twey

It was a complete script, not a template. Nevertheless, are you certain there was no whitespace before the opening <?php? If there were, the script would fail to work.

sorry, i meant script.. :) deff no white space, certain
12-13-2006, 02:52 PM
Twey

Quote:

Originally Posted by mwinter

There are some lingering HTTP/1.0 user agents

Surely they don't send an Host header, and so are completely broken on the Web of today?

Quote:

deff no white space, certain

No text of any kind? No linebreaks, spaces, tabs, DOCTYPEs?
12-13-2006, 03:07 PM
mwinter

Quote:

Originally Posted by Twey

Surely they don't send an Host header, and so are completely broken on the Web of today?

No, not all. Some implemented the Host header as an extension so they can just about manage. NN4, for example.

Mike
12-13-2006, 03:13 PM
munkynpunky

nothing,

this is a copy/paste

PHP Code:

<?php $url = http://www.en4cer.co.uk/downloads/' . $_SERVER['QUERY_STRING']; header("Location: $url"); ?> <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd"> <html> <head> <title>Ades Design</title> </head> <body> Warning: your browser does not support HTTP correctly. It is likely that a large portion of the Web will be broken for you. You should have been sent to <a href="<?php print $url; ?>"><?php print $url; ?></a>. </body> </html>
12-13-2006, 03:51 PM
Twey

Ah! I apologise. I missed a single quote (') before http: on the second line. I've edited the original.
12-13-2006, 04:25 PM
munkynpunky

hmm, ok thats not worked..

basically what happens is

on the website, it shows the name of the download then the amount of downloaded times...

ie.. DOWNLOAD1 - 5641

you click on DOWNLOAD1 and it takes you to a promt to enter a word..

once you enter the work it takes you to the actual file and starts the download

everything works up until the locating the file..