Implementation to send variables through the url (with javascript) like PHP $_GET.

Still bigger than it has to be.

There's no point in calling a function every time you want to get a variable. The query string isn't going to change, so you might as well just store everything in an object at the start and avoid the overhead. Also, that script fails to take into consideration the non-existance of window.location.search, the use of semicolons to separate variables, and the use of URL-encoded characters.

Quote:

---

Originally Posted by Twey

Also, that script fails to take into consideration the non-existance of window.location.search

---

Actually, if there is no query string the function returns undefined. So I don't have to deal with that.

Semicolons? I've never seen any site where the get variables are seperated with semicolons.

http://www.simplemachines.org/community/

Oh thank twey and DimX for improving my code. I was using it because of my non-serverside-language-enabled site in tripod and my code was limited but yours rocks. Thanks all you guyz. I think that it can even handle ajax requests. But I must try.Thanks again.:D

Quote:

---

Originally Posted by Twey

http://www.simplemachines.org/community/

---

Oh well, fine :p here's the "perfect" function:

Code:

---

function $_GET(key_str) {
    if(window.location.search) {
        var query = window.location.search.substr(1);
        var pairs = query.split(/&|;/);
        for(var i = 0; i < pairs.length; i++) {
            var pair = pairs[i].split("=");
            if(unescape(pair[0]) == key_str)
                return unescape(pair[1]);
        }
    }
}

alert( $_GET("p") );

---

Btw. yes, it could be done only once when the page loads:

Code:

---

var $_GET = new Array();
if(window.location.search) {
    var query = window.location.search.substr(1);
    var pairs = query.split(/&|;/);
    for(var i = 0; i < pairs.length; i++) {
        var pair = pairs[i].split("=");
        $_GET[unescape(pair[0])] = unescape(pair[1]);
    }
}

alert( $_GET["p"] );

---

That's perfect DimX,Twey!!!

Oh it does not work with ajax calls probably because it cannot find window.location in ajax requests.

Quote:

---

Originally Posted by DimX

var $_GET = new Array();
if(window.location.search) {
var query = window.location.search.substr(1);
var pairs = query.split(/&|;/);
for(var i = 0; i < pairs.length; i++) {
var pair = pairs[i].split("=");
$_GET[unescape(pair[0])] = unescape(pair[1]);
}
}

alert( $_GET["p"] );

---

$ should be reserved for system identifiers in Javascript, and I still don't see what's wrong with my original:

Code:

---

<script type="text/javascript">
  var _GET = location.href.substr(window.location.href.indexOf('?') + 1).split(/&|;/);
  for(var i in _GET)
    if(_GET[i].indexOf('=') === -1)
      _GET[decodeURIComponent(_GET[i])] = '';
    else _GET[decodeURIComponent(_GET[i].substr(0, _GET[i].indexOf('=')))] = decodeURIComponent(_GET[i].substr(_GET[i].indexOf('=') + 1));
</script>

---

Quote:

---

Originally Posted by shachi

Oh it does not work with ajax calls probably because it cannot find window.location in ajax requests.

---

It won't work with AJAX calls, because scripts on a page loaded via AJAX aren't even called unless you do so manually, and then they refer to the loading page's window.location, not the loaded page.

Quote:

---

Originally Posted by Twey

and then they refer to the loading page's window.location, not the loaded page.

---

That's what I meant by

Quote:

---

Originally Posted by me

probably because it cannot find window.location in ajax requests

---

Quote:

---

Originally Posted by Twey

$ should be reserved for system identifiers in Javascript,

---

It means that the prototype $ function isn't valid too?? And is it a should or a must??

Quote:

---

Originally Posted by Twey

... and I still don't see what's wrong with my original

---

Nothing, it's perfect, I was just using another technique ;)