Check this script??? I know its Bad.

Hey guys... I just through a script together really quick. can you check it out... Dosent seem to work...

Code:

---

    <form method='post' action='install.php?step=1'>
    <table>
    <tr>
      <td>MySQL User:</td>
      <td><input type='text' name='muser' size='20'></td>
    </tr>
    <tr>
      <td>MySQL Password:</td>
      <td><input type='text' name='mpass' size='20'></td>
    </tr>
    <tr>
      <td>MySQL Database:</td>
      <td><input type='text' name='mdata' size='20'></td>
    </tr>
    <tr>
 
    <td>Make sure all the above info is correct.</td>
     
      <td><input type='submit' name='submit' value='Submit'></td>
    </tr>
    </table>
    </form>";

   

    }else{
    $muser = $_POST['muser']; $mpass = $_POST['mpass'];
    $mdata = $_POST['mdata'];
   
    if(empty($muser) || empty($mpass) || empty($mdata) ||{
      Echo"<b>Error:</b> You have some boxes with No info in them, You MUST fill in EVERY BOX!";
      die();
    }

// Connect to Check
    mysql_connect ("localhost", "$muser", "$mpass") or die(mysql_error());
    mysql_select_db ("$mdata");

    // Create Tables

mysql_query("CREATE TABLE `request` (
      `Habbo Name` varchar(20) NOT NULL default '',
      `Song Request` varchar(50) NOT NULL default '',
      `Shoutout\Joke` varchar(10) NOT NULL default '',
      PRIMARY KEY  (`Habbo Name`)
    ) TYPE=MyISAM") or die(mysql_error());

---

I know its really bad but i need help... :]

Demo at http://smileyoureahabbo.freepgs.com/install.php

Code:

---

    if(empty($muser) || empty($mpass) || empty($mdata) ||{

---

Forgot to close the condition.

err??? How Do You Do That... lol i'm dumb.

Indubitably.

Code:

---

    if(empty($muser) || empty($mpass) || empty($mdata)){

---

Its still not working...

Code:

---

    <form method='post' action='install.php?step=1'>
    <table>
    <tr>
      <td>MySQL User:</td>
      <td><input type='text' name='muser' size='20'></td>
    </tr>
    <tr>
      <td>MySQL Password:</td>
      <td><input type='text' name='mpass' size='20'></td>
    </tr>
    <tr>
      <td>MySQL Database:</td>
      <td><input type='text' name='mdata' size='20'></td>
    </tr>
    <tr>
 
    <td>Make sure all the above info is correct.</td>
     
      <td><input type='submit' name='submit' value='Submit'></td>
    </tr>
    </table>
    </form>";

   

    }else{
    $muser = $_POST['muser']; $mpass = $_POST['mpass'];
    $mdata = $_POST['mdata'];
   
    if(empty($muser) || empty($mpass) || empty($mdata)){
      Echo"<b>Error:</b> You have some boxes with No info in them, You MUST fill in EVERY BOX!";
      die();
    }

// Connect to Check
    mysql_connect ("localhost", "$muser", "$mpass") or die(mysql_error());
    mysql_select_db ("$mdata");

    // Create Tables

mysql_query("CREATE TABLE `request` (
      `Habbo Name` varchar(20) NOT NULL default '',
      `Song Request` varchar(50) NOT NULL default '',
      `Shoutout\Joke` varchar(10) NOT NULL default '',
      PRIMARY KEY  (`Habbo Name`)
    ) TYPE=MyISAM") or die(mysql_error());

---

demo: http://smileyoureahabbo.freepgs.com/install.php

hmm....

Can you give us the error(s) you get?

It shows the accual text thats in the file on the page:

Code:

---

"; }else{ $muser = $_POST['muser']; $mpass = $_POST['mpass']; $mdata = $_POST['mdata']; if(empty($muser) || empty($mpass) || empty($mdata)){ Echo"Error: You have some boxes with No info in them, You MUST fill in EVERY BOX!"; die(); } // Connect to Check mysql_connect ("localhost", "$muser", "$mpass") or die(mysql_error()); mysql_select_db ("$mdata"); // Create Tables mysql_query("CREATE TABLE `request` ( `Habbo Name` varchar(20) NOT NULL default '', `Song Request` varchar(50) NOT NULL default '', `Shoutout\Joke` varchar(10) NOT NULL default '', PRIMARY KEY (`Habbo Name`) ) TYPE=MyISAM") or die(mysql_error());

---

You can see what I meen at http://smileyoureahabbo.freepgs.com/install.php

-sighs-

Twey you have any idea?

Oh, I see... it looks as though you've copied and pasted the script from somewhere and missed a big chunk off the top.

Not quite,
I wrote it by looking at another script. Some of it was changed, All i want it to do is ask for the db username, Password, And DB and create the tabel.

Twey you have any ideaaa on how to fix this???

where is the if part for the

PHP Code:

---

}else{ $muser = $_POST['muser']; $mpass = $_POST['mpass']; $mdata = $_POST['mdata'] 


---

if it exist before the <form></form> script then u should

PHP Code:

---

</form><? } else { 
// the rest of the code here
?>

---

i think.... :p

Dont see it...

what dont u see?

the if part for the else clause or what m referring to? :p

I dont see

Code:

---

</form><? } else { 
// the rest of the code here
?>

---

And the if part... Is the if part this?:

Code:

---

if(empty($muser) || empty($mpass) || empty($mdata)){
      Echo"<b>Error:</b> You have some boxes with No info in them, You MUST fill in EVERY BOX!";
      die();
    }

---

the script should like something like :

PHP Code:

---

<?if (condition) { ?>
<form method='post' action='install.php?step=1'>
    <table>
    <tr>
      <td>MySQL User:</td>
      <td><input type='text' name='muser' size='20'></td>
    </tr>
    <tr>
      <td>MySQL Password:</td>
      <td><input type='text' name='mpass' size='20'></td>
    </tr>
    <tr>
      <td>MySQL Database:</td>
      <td><input type='text' name='mdata' size='20'></td>
    </tr>
    <tr>
   
     <td>Make sure all the above info is correct.</td>
       
      <td><input type='submit' name='submit' value='Submit'></td>
    </tr>
    </table>
    </form><?
     }else{
    $muser = $_POST['muser']; $mpass = $_POST['mpass'];
    $mdata = $_POST['mdata']; 
    }
    if(empty($muser) || empty($mpass) || empty($mdata) ||{
      Echo"<b>Error:</b> You have some boxes with No info in them, You MUST fill in EVERY BOX!";
      die();
    }

// Connect to Check
    mysql_connect ("localhost", "$muser", "$mpass") or die(mysql_error());
    mysql_select_db ("$mdata");

    // Create Tables

mysql_query("CREATE TABLE `request` (
      `Habbo Name` varchar(20) NOT NULL default '',
      `Song Request` varchar(50) NOT NULL default '',
      `Shoutout\Joke` varchar(10) NOT NULL default '',
      PRIMARY KEY  (`Habbo Name`)
    ) TYPE=MyISAM") or die(mysql_error()); ?>

---

dunno how to highlight the correction(s) that i think should be corrected? (redundant huh?) :D

And what should the condition be, cause i'm stupid...

if that is the case, that if part should be before the else part :p

whaa?

Quote:

---

Originally Posted by jad9321

And what should the condition be, cause i'm stupid...

---

cheer up kiddo.... just a newbie thing.... dont look down on urself... :D

lol. Ok.

Quote:

---

if that is the case, that if part should be before the else part

---

huh??

ok...ok.... sorry thought u might catch what m trying to say .... give u what i think should be the outlook of the php script....

PHP Code:

---

<? if(empty($muser) || empty($mpass) || empty($mdata) ||{
      Echo"<b>Error:</b> You have some boxes with No info in them, You MUST fill in EVERY BOX!";
      die();
    } ?>
<form method='post' action='install.php?step=1'>
    <table>
    <tr>
      <td>MySQL User:</td>
      <td><input type='text' name='muser' size='20'></td>
    </tr>
    <tr>
      <td>MySQL Password:</td>
      <td><input type='text' name='mpass' size='20'></td>
    </tr>
    <tr>
      <td>MySQL Database:</td>
      <td><input type='text' name='mdata' size='20'></td>
    </tr>
    <tr>
   
     <td>Make sure all the above info is correct.</td>
       
      <td><input type='submit' name='submit' value='Submit'></td>
    </tr>
    </table>
    </form><?
     }else{
    $muser = $_POST['muser']; $mpass = $_POST['mpass'];
    $mdata = $_POST['mdata']; 
    }
// Connect to Check
    mysql_connect ("localhost", "$muser", "$mpass") or die(mysql_error());
    mysql_select_db ("$mdata");

    // Create Tables

mysql_query("CREATE TABLE `request` (
      `Habbo Name` varchar(20) NOT NULL default '',
      `Song Request` varchar(50) NOT NULL default '',
      `Shoutout\Joke` varchar(10) NOT NULL default '',
      PRIMARY KEY  (`Habbo Name`)
    ) TYPE=MyISAM") or die(mysql_error()); ?>

---

this is a 100% perfect script.... :D

Now i'm getting this error:

Parse error: parse error, unexpected '{' in /fpgs/fpgshttpd/smileyoureahabbo/install.php on line 1

Quote:

---

Originally Posted by Twey

Indubitably.

Code:

---

    if(empty($muser) || empty($mpass) || empty($mdata)){

---

---

:eek: use the code above on line 1 :o
might help

if there still exist errors, its now way out of my league :o

sorry :(

So it should look like this?

Code:

---

<? if(empty($muser) || empty($mpass) || empty($mdata)){
      Echo"<b>Error:</b> You have some boxes with No info in them, You MUST fill in EVERY BOX!";
      die();
    } ?>
<form method='post' action='install.php?step=1'>
    <table>
    <tr>
      <td>MySQL User:</td>
      <td><input type='text' name='muser' size='20'></td>
    </tr>
    <tr>
      <td>MySQL Password:</td>
      <td><input type='text' name='mpass' size='20'></td>
    </tr>
    <tr>
      <td>MySQL Database:</td>
      <td><input type='text' name='mdata' size='20'></td>
    </tr>
    <tr>
 
    <td>Make sure all the above info is correct.</td>
     
      <td><input type='submit' name='submit' value='Submit'></td>
    </tr>
    </table>
    </form><?
    }else{
    $muser = $_POST['muser']; $mpass = $_POST['mpass'];
    $mdata = $_POST['mdata'];
    }
// Connect to Check
    mysql_connect ("localhost", "$muser", "$mpass") or die(mysql_error());
    mysql_select_db ("$mdata");

    // Create Tables

mysql_query("CREATE TABLE `request` (
      `Habbo Name` varchar(20) NOT NULL default '',
      `Song Request` varchar(50) NOT NULL default '',
      `Shoutout\Joke` varchar(10) NOT NULL default '',
      PRIMARY KEY  (`Habbo Name`)
    ) TYPE=MyISAM") or die(mysql_error()); ?>

---

yeah :D more or less something like that :)

still not working... It dosent seem to like the }else{ thingy....

we should probably wait for Twey to be online again.... :o
can't help you beyond what i have said on my earlier posts :cool:

Wow... I'm good... lol I was messing around with it and i got it to work!

thats nice to hear :p dont get cocky though :D