PDA

View Full Version : Fade-in Slideshow 2.1 not showing up in IE



jkheuer
10-02-2011, 10:54 PM
1) Script Title: Ultimate Fade-in slideshow (v2.1)

2) Script URL (on DD): http://www.dynamicdrive.com/dynamicindex14/fadeinslideshow.htm

3) Describe problem: works fine in safari, firefox, but nothing shows in in IE. Here's the site.

http://alonzoguitars.com/

any help is greatly appreciated, as I am not so good with javascript. Thanks.

jscheuer1
10-03-2011, 12:18 AM
Your page is in violation of Dynamic Drive's usage terms (http://www.dynamicdrive.com/notice.htm), which, among other things, state that the script credit must appear in the source code of the page(s) using the script. Please reinstate the notice first.

Get rid of the two highlighted bits:


<script language="javascript1.2">
<!--

/* swap menu buttons */

function swapButtons(buttonone, buttontwo)
{
if (document.images)
{
document[buttonone].src= buttontwo;
}
}
/*SWAP BETWEEN LARGE IMAGES*/

function swapImages(picone, pictwo)
{
if (document.images)
{
document[picone].src=pictwo;
}
}
-->

var mygallery=new fadeSlideShow({
wrapperid: "fadeshow1", //ID of blank DIV on page to house Slideshow
dimensions: [700, 518], //width/height of gallery in pi . . .

By way of explanation - if you're interested, they're holdovers from when older browsers needed to be protected from javascript. However, these older browsers are almost never used these days, and if they were couldn't render a modern web page with or without javascript.

Further, you could still use them. But the second one would need to be (and probably was originally to work as intended):


// -->

But it's best not to use them as some modern browsers might ignore your javascript contained within them.

Basically other browsers are error correcting them for you, while IE sees the second one as what it technically is - a syntax error, so stops processing the script at that point.

jkheuer
10-03-2011, 01:33 AM
thanks for the fix! and I put the credit in there. sorry about that.