View Full Version : External Jave Script File Problem

03-01-2010, 10:50 PM

I am struggling with an external Javascript file I have created. Currently the website I am building is only on my computer and has not been uploaded to the server. So the problem.......

The java script works when embedded into the html page file, however when I put it into a .JS file and attach it via dreamweaver the script effect I require does not work. I am at a loss as to why.

My java file is _preloadimages.js
The script is

<script type="text/javascript">
function MM_preloadImages() { //v3.0
var d=document; if(d.images){ if(!d.MM_p) d.MM_p=new Array();
var i,j=d.MM_p.length,a=MM_preloadImages.arguments; for(i=0; i<a.length; i++)
if (a[i].indexOf("#")!=0){ d.MM_p[j]=new Image; d.MM_p[j++].src=a[i];}}

function MM_swapImgRestore() { //v3.0
var i,x,a=document.MM_sr; for(i=0;a&&i<a.length&&(x=a[i])&&x.oSrc;i++) x.src=x.oSrc;

function MM_findObj(n, d) { //v4.01
var p,i,x; if(!d) d=document; if((p=n.indexOf("?"))>0&&parent.frames.length) {
d=parent.frames[n.substring(p+1)].document; n=n.substring(0,p);}
if(!(x=d[n])&&d.all) x=d.all[n]; for (i=0;!x&&i<d.forms.length;i++) x=d.forms[i][n];
for(i=0;!x&&d.layers&&i<d.layers.length;i++) x=MM_findObj(n,d.layers[i].document);
if(!x && d.getElementById) x=d.getElementById(n); return x;

function MM_swapImage() { //v3.0
var i,j=0,x,a=MM_swapImage.arguments; document.MM_sr=new Array; for(i=0;i<(a.length-2);i+=3)
if ((x=MM_findObj(a[i]))!=null){document.MM_sr[j++]=x; if(!x.oSrc) x.oSrc=x.src; x.src=a[i+2];}

// Comma separated list of images to rotate
var imgs = new Array('../Pictures/Tony/1.jpg','../Pictures/Tony/2.jpg','../Pictures/Tony/logo-pic.jpg','../Pictures/Tony/5.jpg','../Pictures/Tony/12.jpg','../Pictures/Tony/13.jpg');
// delay in milliseconds between image swaps 1000 = 1 second
var delay = 3000;
var counter = 0;

function preloadImgs(){
for(var i=0;i<imgs.length;i++){

function randomImages(){
if(counter == (imgs.length)){
counter = 0;
MM_swapImage('rotator', '', imgs[counter++]);
setTimeout('randomImages()', delay);



My HTML is:

<title>Untitled Document</title>
<link href="Untitled-300.css" rel="stylesheet" type="text/css" />
<body onload="preloadImgs();randomImages();">
<script type="text/javascript" src="../script/_preloadImages.js"></script>
<div id="wrapper">
<div id="header"><img src="../Pictures/Tony/splash_header.jpg" width="962" height="66" /></div>
<div id="nav"><img src="../Pictures/Tony/nav3.jpg" width="962" height="48" /></div>
<div id="left">
<div id="left-top"><img src="../Pictures/Tony/splash_button.jpg" width="345" height="170" /></div>
<div id="left bottom"><img src="../Pictures/Tony/splash_featlistings3.jpg" width="345" height="207" /></div>
<div id="right"><img src="../Pictures/Tony/1.jpg" name="rotator" width="617" height="377" id="rotator" /></div>
<div id="bottom"><img src="../Pictures/Tony/splash_footer3.gif" width="962" height="283" /></div>


Any Help would be very much appreciated.