PDA

View Full Version : Create a external Javascript file



regaul2
10-27-2009, 02:37 PM
Found the following code and would like to make the javascript part an external file. Thought it would be easy to convert, but I can't get it to work at all. Can anyone help?

HEAD>

<SCRIPT LANGUAGE="JavaScript">

<!-- Begin
function Login(){
var done=0;
var username=document.login.username.value;
username=username.toLowerCase();
var password=document.login.password.value;
password=password.toLowerCase();
if (username=="member1" && password=="password1") { window.location="page1.html"; done=1; }
if (username=="member2" && password=="password2") { window.location="page2.html"; done=1; }
if (username=="member3" && password=="password3") { window.location="page3.html"; done=1; }
if (done==0) { alert("Invalid login!"); }
}
// End -->
</SCRIPT>

<!-- STEP TWO: Paste this code into the BODY of your HTML document -->

<BODY>

<center>
<form name=login>
<table width=225 border=1 cellpadding=3>
<tr><td colspan=2><center><font size="+2"><b>Members-Only Area!</b></font></center></td></tr>
<tr><td>Username:</td><td><input type=text name=username></td></tr>
<tr><td>Password:</td><td><input type=text name=password></td></tr>
<tr><td colspan=2 align=center><input type=button value="Login!" onClick="Login()"></td></tr>
</table>
</form>
</center>

traq
10-27-2009, 03:20 PM
what are you having problems with, exactly? there's not really anything to convert. don't put the <script> tags in the external file; add your tags to the <head> section:
<script type="text/javascript" src="path/to/your/external.js"></script>
If there's something else you're having trouble with, let us know what it is.

On a side note, javascript is too insecure to rely on for passwords. If you actually need access control (rather than just a "reminder" that it's member-only), you need a server-side script (like PHP).

regaul2
10-27-2009, 05:28 PM
Traq, yes I thought if would be that simple, but I keep getting a 'object expected' error.

Here is my external js file called authUser.js:

<!-- Begin
function Login(){
var done=0;
var username=document.login.username.value;
username=username.toLowerCase();
var password=document.login.password.value;
password=password.toLowerCase();
if (username=="guest" && password=="enter") { window.location="contact-us.asp"; done=1; }
if (username=="member2" && password=="password2") { window.location="page2.html"; done=1; }
if (username=="member3" && password=="password3") { window.location="page3.html"; done=1; }
if (done==0) { alert("Invalid login!"); }
}
// End -->

Here is my page code:

<script type="text/javascript" src="../JScript/authUser.js"></script>
</head>
<body>
<div id="container">
<!--#include virtual="/includes/main-header.asp"-->
<div id="left_menu">
<!--#include virtual="/includes/menu-technical-support.asp"-->
</div>
<div id="content">
<center>
<center>
<form name=login>
<table width=225 border=1 cellpadding=3>
<tr><td colspan=2><center><font size="+2"><b>Members-Only Area!</b></font></center></td></tr>
<tr><td>Username:</td><td><input type="text" name="username"></td></tr>
<tr><td>Password:</td><td><input type="password" name="password"></td></tr>
<tr><td colspan=2 align=center><input type=button value="Login!" onClick="Login()"></td></tr>
</table>
</form>
</center>
</div>
<!--#include virtual="/includes/main-footer.asp"-->
</div>
</div>
<!--#include virtual="/includes/common-web-stats.asp"-->
</body>
</html>

I am not a programmer by any means, so I just can not figure it out. It works fine when everthing is on the page together, but when seperated out like I want to do, it just does not want to work.

jscheuer1
10-27-2009, 06:32 PM
You cannot have:


<!-- Begin

In the external file, this would be OK:


// <!-- Begin

That will probably take care of it, just in case though, here's my stuff and links to more on external javascript files:

Use a text editor to save the script, call it 'file_name.js' where 'file_name' can be any valid file name of your choosing. Substitute the name of your external .js file for some.js in the below:


<script src="some.js" type="text/javascript"></script>

Common problems arise when:

1 ) The script file is not in the directory specified. In the above example it must be in the same directory as the page(s) that use it. Below, it can be in the scripts directory off of the root of a domain:


<script src="http://www.somedomain.com/scripts/some.js" type="text/javascript"></script>

2 ) Opening, closing and/or 'hiding' tags are left in the external file. This means that you must strip:
<script>
<!--and
//-->
</script>and any of their many variations from the beginning and end of the external file.

3 ) The external call (<script src="some.js" type="text/javascript"></script>) is not inserted into the page at the correct spot. The external call must be inserted at the same place on the page where the script was/would have been.

4 ) Paths to other files (if) used by the script are no longer valid due to its location. This is only a problem if the external script is kept in a different directory than the page it was working on when it was an internal script. To correct this, use absolute paths inside the script. Absolute path examples:


http://www.somedomain.com/images/button.gif

http://www.somedomain.com/~mysitename/index.html

5 ) Inappropriately combining two or more scripts into one external file. Usually external scripts can be combined if one knows enough about scripting to do so properly. Even then it is possible to overlook something.

A rule of thumb when testing is, if it won't work on the page, it won't work as an external file either.

One other thing, if this is a DD script or any script that requires the credit remain for legal use, include the credit in the on page call, ex (see usage terms (http://www.dynamicdrive.com/notice.htm) for more info on this, especially item 4 from the terms):


<script src="some.js" type="text/javascript">
/***********************************************
* IFrame SSI script II- Dynamic Drive DHTML code library (http://www.dynamicdrive.com)
* Visit DynamicDrive.com for hundreds of original DHTML scripts
* This notice must stay intact for legal use
***********************************************/
</script>

Make sure to retain all the 'decorations', as these include begin and end javascript comment delimiters, without which the script won't function.

There is also info here:

http://www.javascriptkit.com/javatutors/external.shtml

regaul2
10-27-2009, 08:26 PM
John -

Stripping the external code of <!-- Begin did the trick.

Thanks everyone for your hellp