jscheuer1
10-03-2009, 05:58 AM
1) Script Title: Ultimate Fade-in slideshow (v2.0)
2) Script URL (on DD): http://www.dynamicdrive.com/dynamicindex14/fadeinslideshow.htm
3) Describe problem: This is some really minor stuff.
Great Script By the way DD!
OK, back to the minor stuff. In FF error console, there are 'problems' with css width and height specifications lacking units for the toggler buttons when used. This is only because this was omitted from the script. In most cases the images for the buttons are the size that they are, so this doesn't affect presentation or layout, but in cases where these may differ, there will be problems with presentation and/or layout. In any case - there will be an error in the console (declaration dropped) even when the page looks and acts fine, but also when it doesn't - and since these dimensions are added as part of strings for creating these elements, the error will be hard to track down when it does cause a problem (the console cannot point to any line number for it).
Also there are oddities in accommodating legacy IE browsers for the 'hand' cursor style. It is done two different ways. Which is correct?
In any case, since all IE browsers will recognize 'hand' as equivalent to 'pointer', why not just make the prototypical value for that sort of cursor based upon browser - thus avoiding any chicken or the egg issues over:
cursor:hand;cursor:pointer;
vs:
cursor:pointer;cursor:hand;
Which are the two ways you have it in the script. This will likely never cause any real issue - just an error that, since it is once again a part of a generated string, will have no line number - potentially confusing folks trying to debug any real issues they may have with the code.
I've made these two adjustments (and only these two adjustments) in the code:
2891
2) Script URL (on DD): http://www.dynamicdrive.com/dynamicindex14/fadeinslideshow.htm
3) Describe problem: This is some really minor stuff.
Great Script By the way DD!
OK, back to the minor stuff. In FF error console, there are 'problems' with css width and height specifications lacking units for the toggler buttons when used. This is only because this was omitted from the script. In most cases the images for the buttons are the size that they are, so this doesn't affect presentation or layout, but in cases where these may differ, there will be problems with presentation and/or layout. In any case - there will be an error in the console (declaration dropped) even when the page looks and acts fine, but also when it doesn't - and since these dimensions are added as part of strings for creating these elements, the error will be hard to track down when it does cause a problem (the console cannot point to any line number for it).
Also there are oddities in accommodating legacy IE browsers for the 'hand' cursor style. It is done two different ways. Which is correct?
In any case, since all IE browsers will recognize 'hand' as equivalent to 'pointer', why not just make the prototypical value for that sort of cursor based upon browser - thus avoiding any chicken or the egg issues over:
cursor:hand;cursor:pointer;
vs:
cursor:pointer;cursor:hand;
Which are the two ways you have it in the script. This will likely never cause any real issue - just an error that, since it is once again a part of a generated string, will have no line number - potentially confusing folks trying to debug any real issues they may have with the code.
I've made these two adjustments (and only these two adjustments) in the code:
2891