External Javascript for Flash Detection Code

[taya74]

I know how to do a basic external Javascript (and don't know much about Javascript) but can't work out how to do it for the Flash Detection Code - I presume all the coding in the head for it goes into a txt file saved as external.js and then the following replaces it


<SCRIPT language="JavaScript" SRC="external.js"></SCRIPT>

But what about the code in the body - I presume this stays in the body but how do I point that code to the external.js (I have 2 flash files in the one page as well but will have the same flash detection coding) ie


<script language="JavaScript" type="text/javascript">
<!--
var hasRightVersion = DetectFlashVer(requiredMajorVersion, requiredMinorVersion, requiredRevision);
if(hasRightVersion) { // if we've detected an acceptable version
var oeTags = '<object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000"'
+ 'width="742" height="121"'
+ 'codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab">'
+ '<param name="movie" value="perthsky.swf" /><param name="quality" value="high" /><param name="bgcolor" value="#333333" />'
+ '<embed src="perthsky.swf" quality="high" bgcolor="#333333" '
+ 'width="742" height="121" name="perthsky" align="middle"'
+ 'play="true"'
+ 'loop="false"'
+ 'quality="high"'
+ 'allowScriptAccess="sameDomain"'
+ 'type="application/x-shockwave-flash"'
+ 'pluginspage="http://www.macromedia.com/go/getflashplayer">'
+ '<\/embed>'
+ '<\/object>';
document.write(oeTags); // embed the flash movie
} else { // flash is too old or we can't detect the plugin
var alternateContent = '<img src="perthcitypano2.jpg" />';
document.write(alternateContent); // insert non-flash content
}
// -->
</script>

Thanks

[jscheuer1]

The language attribute has been deprecated and the type attribute is required. So use:


<script type="text/javascript" src="external.js"></script>

But why name it external.js? I'd call it flash_detect.js - but you may name it anything you like.

For the same reasons mentioned above, the body code should open like:


<script type="text/javascript">
<!--
var hasRightVersion = DetectFl . . .

You don't need to do anything to get the body code to access the external script. As long as that external file is a valid script file, all other scripts on the page may reference it.

Here are my pointers for external scripts:


Use a text editor to save the script, call it 'file_name.js' where 'file_name' can be any valid file name of your choosing. Substitute the name of your external .js file for some.js in the below:


<script src="some.js" type="text/javascript"></script>

Common problems arise when:

1 ) The script file is not in the directory specified. In the above example it must be in the same directory as the page(s) that use it. Below, it can be in the scripts directory off of the root of a domain:


<script src="http://www.somedomain.com/scripts/some.js" type="text/javascript"></script>

2 ) Opening, closing and/or 'hiding' tags are left in the external file. This means that you must strip:
<script>
<!--and
//-->
</script>and any of their many variations from the beginning and end of the external file.

3 ) The external call (<script src="some.js" type="text/javascript"></script>) is not inserted into the page at the correct spot. The external call must be inserted at the same place on the page where the script was/would have been.

4 ) Paths to other files (if) used by the script are no longer valid due to its location. This is only a problem if the external script is kept in a different directory than the page it was working on when it was an internal script. To correct this, use absolute paths inside the script. Absolute path examples:


http://www.somedomain.com/images/button.gif

http://www.somedomain.com/~mysitename/index.html

5 ) Inappropriately combining two or more scripts into one external file. Usually external scripts can be combined if one knows enough about scripting to do so properly. Even then it is possible to overlook something.

A rule of thumb when testing is, if it won't work on the page, it won't work as an external file either.

One other thing, if this is a DD script or any script that requires the credit remain for legal use, include the credit in the on page call, ex:


<script src="some.js" type="text/javascript">
/***********************************************
* IFrame SSI script II- © Dynamic Drive DHTML code library (http://www.dynamicdrive.com)
* Visit DynamicDrive.com for hundreds of original DHTML scripts
* This notice must stay intact for legal use
***********************************************/
</script>

Make sure to retain all the 'decorations', as these include begin and end javascript comment delimiters, without which the script won't function.

There is also info here:

http://www.javascriptkit.com/javatutors/external.shtml

[taya74]

Thanks - it now works perfectly!