PDA

View Full Version : Random iframe not so random



bistromath
07-03-2008, 10:01 PM
1) Script Title: random iframe content

2) Script URL (on DD): www.dynamicdrive.com/dynamicindex17/randomiframe.htm

3) Describe problem: Instead of picking one of my included files randomly, it just goes with the second one. Here is my code:

<script language="JavaScript1.2">

//Random iframe content- Dynamic Drive (www.dynamicdrive.com)
//For full source code, and Terms Of use, visit http://dynamicdrive.com
//This credit MUST stay intact for use

var ie=document.all&&navigator.userAgent.indexOf("Opera")==-1
var dom=document.getElementById&&navigator.userAgent.indexOf("Opera")==-1

//Specify IFRAME display attributes
var iframeprops='width=380 height=430 marginwidth="0" marginheight="0" hspace="0" vspace="0" frameborder="0" scrolling="no"'

//Specify random URLs to display inside iframe
var randomcontent=new Array()
randomcontent[0]="http://www.randyschreiber.com/random1.html"
randomcontent[0]="http://www.randyschreiber.com/random2.html"


//No need to edit after here
if (ie||dom)
document.write('<iframe id="dynstuff" src="" '+iframeprops+'></iframe>')

function random_iframe(){
if (ie||dom){
var iframeobj=document.getElementById? document.getElementById("dynstuff") : document.all.dynstuff
iframeobj.src=randomcontent[Math.floor(Math.random()*randomcontent.length)]
}
}

window.onload=random_iframe

</script>

Thanks for taking a look, any ideas what's wrong?

~Bistromath

Nile
07-03-2008, 10:55 PM
At the top of your script find this:


randomcontent[0]="http://www.randyschreiber.com/random1.html"
randomcontent[0]="http://www.randyschreiber.com/random2.html"

The code only sees one page. randomcontent[0] will only overlap. You have to increase the numbers as you go along, try this:


randomcontent[0]="http://www.randyschreiber.com/random1.html"
randomcontent[1]="http://www.randyschreiber.com/random2.html"

bistromath
07-21-2008, 03:42 PM
great nile, thanks for the reply!