Inventions - Any suggestions?

[magicyte]

I, Magicyte, a Junior Coder, coded a pretty cool game for a school project. It took about a month to make, and it was worth it. It is called Inventions and is based on some of Thomas Edison's inventions. Nine of them, in fact. The point of the game is to retrieve the nine in order to win the Nobel Prize. There is a problem, though. Creatures known as "Swipes" are trying to steal them. In fact, they stole the nine inventions from the beginning. Each level gets harder, but you never lose. You use the arrow keys to move around. It is for Internet Explorer 4 and up, all Firefox versions and Opera versions. I left an attachment for people to look at. It has the code and everything. If you could open the .zip file and look at the code, please leave a comment or a suggestion on the code to make it better. If there is an error that you may have found, please let me know immediately. Thanx and please reply on the double!

-magicyte

IMPORTANT! INSTALLATION INSTRUCTIONS!
P.S. To install, click on the Attached File below as a .zip file. It is called Inventions 1.zip. Once a new window opens asking what you want to do with it, either Open or Save it, click Save. It would be best if you could save it to My Documents. It shouldn't take long at all to download. Once that has been downloaded, open up My Documents. Look for the Inventions 1.zip folder. Once you have found it, open it. Once opened, click on File. Look for the option Extract All... Click on it. It will then bring up the Extraction Wizard. Click Next, then click Next again, make sure that the checkbox saying Show Files is checked, and then click Finish. This should open up all of the files. Look for the Internet Explorer file with the name Inventions. Double click on it and then wait. The game should come up. Click on Start in the iFrame and then read the Instructions on how to play. Then you will be able to play. Hope this helps!:)

[magicyte]

If anybody would like to play the video game I made, just let me know. I am in need of a reply to make it better for sale. I am a programmer who needs to know if this code is good. Any good comment would be nice. Possibly a suggestion would be better. Plz reply OTD.

-magicyte

[Nile]

Wow, I never thought of forming javascript in to a fun game, I usually just make effects with it, but that's pretty cool.
One thing would be to add a little beat(music) to the background

[magicyte]

THANK YOU SO VERY MUCH, NILE, FOR REPLYING!!!

-magicyte

[magicyte]

Oh, yeah, DANG!! You gots a lot of posts!!

-magicyte

[techno_race]

You too many.

1898

[magicyte]

Yeah, so?!

----------

What is your suggestion? Did you try it out yet!? It really is an awesome game!!!

----------

I don't understand what you said...

-magicyte

[Twey]

I haven't checked out the game, but your code is incredibly ugly. It could do with a good refactor -- you can make it more modular, more elegant, and probably cut the size of the codebase by about 80%.

[magicyte]

Well, I programmed the thing a while back. all of those if statements can be replaced with

yada ? sdf : lkj;

I didn't know much a while back. It IS ugly, I know, but do you have any idea of how I could make it better, faster, and less ugly?

-magicyte

P.S. What did you mean by ugly? Jumbled? Spaghetti code? Complexed statements?

P.P.S. 日本語が分かります too!

[magicyte]

I do also admit that it is (S)(u)(C)(k)(I)(s)(H). Afterall, I made it for school, and I didn't even know that it was compatible with my school's server, so I ended up dragging my darn PC down to School.

-magicyte

[jr_yeo]

P.P.S. 日本語が分かります too!

i understand Japanese. i think.

[mburt]

i understand Japanese. i think.

Hahaha, I think I do too.

[Twey]

Your general coding style needs serious improvement. Keep your functions modular. You should not have any global variables except a single reference to your top-level namespacing object (unless some functions can be generalised beyond the current application, in which case they may be worthy of a namespacing object of their own). If data needs to be shared between functions, or between calls of a function, that shouldn't be passed as an explicit argument, capture them in a closure — but this is a quite rare scenario. Write functions that do one thing and do it well, generalising as much as possible and then narrowing down their scope using calling functions. Where you can, avoid your functions having side effects, and group all side-effecting functions into a thin layer on top of your rich structure of pure functions. That said, don't be afraid to take advantage of Javascript's OO features. Functional style isn't always the most elegant way to go in a language like Javascript (but it usually is).


P.P.S. 日本語が分かります too!そうですか。どこに習いましたか。

[jr_yeo]

そうですか。どこに習いましたか。

deductive reasoning. :cool:


| I understand English | 日本語が分かります | mi jimpe le jbobau | mi esperanton komprenas | je comprends français | entiendo español | tôi ít hiểu tiếng Việt | ich verstehe ein bisschen Deutsch |

the 1st one, of course, is English. the 2nd is Japanese. the 3rd, I can't my finger on it. the 4th, I think, is Italian. the 5th is French. the 6th is Spanish. the 7th is Vietnamese. the 8th is German. am I wrong? :confused:

and of course, a translator (http://babelfish.yahoo.com/) :p

[Twey]

Wrong on one count: what you took as Italian was actually Esperanto. The one you couldn't name was Lojban. Good job getting all but the conlangs. :)

[jr_yeo]

ok. :cool:

[magicyte]

Actually, I don't understand japanese. How does it all work?

-magicyte

[Twey]

魔法で。
By magic.

[magicyte]

Ha ha ha...

-magicyte

[magicyte]

日本語が分かります余りに

いいえ、真剣に。 いかに日本語を学んだか。

日本語

それをどこで学ぶか知っているか。私は。ところで、それはマジックとまたはマジックによって行うか。 私はちょうど知りたいと思った…

-magicyte

[Twey]

二年前ごろから勉強していますが、ちょっと休んだし日本に住んだことがないし完璧ではありません。いつか行って完璧にしたいです。

その日本語はおかしいです。Babelfishとか使いましたか。 :)

[magicyte]

私は多分持っている。 それは理解された。 私は私の中心を告白する。 私の単語がBabelfishのメカニズムを使用して翻訳されるがI。 日本語はどこかに学ばれたか。 あなたが使用する本があるか。 :)

-magicyte

[Twey]

あまり使いませんが、私が薦めるのは「げんき」と言う本しかありません。私ならだいぶインターネットで勉強しましたが、授業にも行きました。

Babelfishのじゃくてんは、かなのみでかいたのはやくせないことですね。 :)

[jr_yeo]

少说废话。:)

[Nile]

Magicyte 、日本語の下に立つか？

[Twey]

Magicyte 、日本語の下に立つか？No, he doesn't stand under Japanese, he's using Babelfish :)

[magicyte]

I do under stand only two things in Japanese :D. It is my Japanese friend's name. His name is Thor O'Connor. This is what he taught me: トア. That is what he taught me. I don't know if it is correct, but that is what his mom named him. Toa! I do not understand Japanese, but I am fluent en espanol.

-magicyte