popup does not work

[runnerjp]

hey guys addid the javascript

Code:


<script language="javascript" type="text/javascript">
<!--
function popitup(url) {
newwindow=window.open(url,'name','height=200,width=150');
if (window.focus) {newwindow.focus()}
return false;
}

// -->
</script>
<a href="uploader.php" onclick="upload you image('uploader.php')"
>update my image</a>

but when the link is clicked it send you to the full page uploader.php with no popup at all :S

how comes... the code on uploader.php is
PHP Code:

<?php



session_start();

//load the config file

include("config.php");

require_once '../settings.php';





//if the for has submittedd

if (isset($_POST['upForm'])){



$file_type = $_FILES['imgfile']['type'];

$file_name = $_FILES['imgfile']['name'];

$file_size = $_FILES['imgfile']['size'];

$file_tmp = $_FILES['imgfile']['tmp_name'];



//check if you have selected a file.

if(!is_uploaded_file($file_tmp)){

echo "Error: Please select a file to upload!. <br>--<a href=\"$_SERVER[PHP_SELF]\">back</a>";

exit(); //exit the script and don't do anything else.

}

//check file extension

$ext = strrchr($file_name,'.');

$ext = strtolower($ext);

if (($extlimit == "yes") && (!in_array($ext,$limitedext))) {

echo "Wrong file extension. <br>--<a href=\"$_SERVER[PHP_SELF]\">back</a>";

exit();

}

//get the file extension.

$getExt = explode ('.', $file_name);

$file_ext = $getExt[count($getExt)-1];



//get users ID

$id = $_SESSION['user_id'];







//get the new width variable.

$ThumbWidth = $img_thumb_width;



//keep image type

if($file_size){

if($file_type == "image/pjpeg" || $file_type == "image/jpeg"){

$new_img = imagecreatefromjpeg($file_tmp);

}elseif($file_type == "image/x-png" || $file_type == "image/png"){

$new_img = imagecreatefrompng($file_tmp);

}elseif($file_type == "image/gif"){

$new_img = imagecreatefromgif($file_tmp);

}

//list width and height and keep height ratio.

list($width, $height) = getimagesize($file_tmp);

$imgratio=$width/$height;

if ($imgratio>1){

$newwidth = $ThumbWidth;

$newheight = $ThumbWidth/$imgratio;

}else{

$newheight = $ThumbWidth;

$newwidth = $ThumbWidth*$imgratio;

}

//function for resize image.

if (function_exists(imagecreatetruecolor)){

$resized_img = imagecreatetruecolor($newwidth,$newheight);

}else{

die("Error: Please make sure you have GD library ver 2+");

}

imagecopyresampled($resized_img, $new_img, 0, 0, 0, 0, $newwidth, $newheight, $width, $height);

//save image

ImageJpeg ($resized_img,"$path_thumbs/$id.$file_ext");

ImageDestroy ($resized_img);

ImageDestroy ($new_img);

//print message

echo "<br>Image Thumb: <a href=\"$path_thumbs/$id.$file_ext\">$path_thumbs/$id.$file_ext</a>";

}



//upload the big image

move_uploaded_file ($file_tmp, "$path_big/$id.$file_ext");



echo "<br>Image Big: <a href=\"$path_big/$id.$file_ext\">$path_big/$id.$file_ext</a>";



echo "<br><br>--<a href=\"$_SERVER[PHP_SELF]\">back</a>";





$query = "INSERT INTO user_images (user_id, ext) VALUES ('$id', '$file_ext')

ON DUPLICATE KEY UPDATE ext = '$file_ext'";

mysql_query($query) or die(mysql_error());



}else{ //if the form hasn't been submitted.



//print the form

echo "<script>

function view_img(img_name){

document[img_name].src = upForm.imgfile.value;

document[img_name].width = 150;

}

</script>\n\n

<br><h3>:: Browse an Image to Upload:</h3>\n

<form method=\"post\" name=\"upForm\" enctype=\"multipart/form-data\" action=\"$_SERVER[PHP_SELF]\">\n

<input type=\"file\" name=\"imgfile\" onchange=\"javascript:view_img('img_vv');\"> <img src='' name='img_vv' width='0'><br>\n

Image width will resize to <b>$img_thumb_width</b> with height ratio.

<br><input type=\"Submit\" name=\"upForm\" value=\"Upload & Resize\">\n

</form>

<a href=\"view_gallery.php\">View Images</a>";

}
?>
if that helps

[jscheuer1]

This (highlighted):



<script language="javascript" type="text/javascript">
<!--
function popitup(url) {
newwindow=window.open(url,'name','height=200,width=150');
if (window.focus) {newwindow.focus()}
return false;
}

// -->
</script>
<a href="uploader.php" onclick="upload you image('uploader.php')"
>update my image</a>

isn't going to do anything.

There are other issues with your javascript, but if you were to do it like so:


<script type="text/javascript">
function popitup(url) {
var newwindow=window.open(url,'name','height=200,width=150');
if (window.focus) {newwindow.focus()}
return false;
}
</script>
<a href="uploader.php" onclick="return popitup(this.href);"
>update my image</a>

it should at least work.