Adding javascript into PHP

[Master-T]

How to add javascript into PHP

How would I make this work?

eg:

Lets say I have this javascript:


<a href="search.htm" onClick="return overlay(this, 'subcontent2', 'rightbottom')">login</a>

and I want to add it into this PHP:




<?php

// Are they a guest?

if ($context['user']['is_guest'])

{

// Show a login box...

// Uncomment below to show login box

// ssi_login();

// ... and a little notice about registering

echo '

Welcome, <b>Guest</b>, Please **THE JAVASCRIPT HERE** or';

echo '

<a href="', $scripturl, '?action=register">register</a>';

}

// Otherwise, a user here :)

else

{

// Show them a nice welcome notice

ssi_welcome();

echo ' ';

// And a logout link

ssi_logout("#");

}

?>

[Master-T]

Don't worry, found a solution:


<a href="#" onclick="return overlay(this, \'subcontent2\', \'rightbottom\')">login</a>

Just add the backslashes.

[StarrRider]

The problem was in your quotes.
Both javascript and PHP share the same quotes (single quote ' and the double quote ") so when you place a piece of javascript code into PHP - you need to tell PHP to ignore the javascript quotes that interfer - as Master-T did - by using the \ character.
Of course - you could also break it up so that the quotes don't interfer with each other - like this:


$link = "return overlay(this, 'subcontent2', 'rightbottom')";
$link = '<a href="search.htm" onClick="'.$link.'">login</a>';

I prefer the latter because I find it easier to read - even it it is more work.

[Twey]

One of many reasons to break out of PHP parsing mode when outputting HTML.
<?php if($context['user']['is_guest']) { ?>

Welcome, <b>Guest</b>.
Please <a href="search.htm" onclick="return overlay(this, 'subcontent2', 'rightbottom');">login</a>
or <a href="<?php echo $scripturl; ?>?action=register">register</a>.

<?php } else {
ssi_welcome();
ssi_logout('#');
} ?>