Heya dj well say I have this page, it's pretty simple but how would I make it so it works better, and I keep the php seperate to the html
<?php
/* connect to the mysql database and use different queries for the count of members */
include 'library/config.php';
include 'library/opendb.php';
//navigation
include("nav.php");
//approved
$a = mysql_query("SELECT * FROM `tblmembers` WHERE `MemberApproved`='A'");
$aCount = mysql_num_rows($a);
//deleted
$d = mysql_query("SELECT * FROM `tblmembers` WHERE `MemberApproved`='D'");
$dCount = mysql_num_rows($d);
//on hold
$h = mysql_query("SELECT * FROM `tblmembers` WHERE `MemberApproved`='H'");
$hCount = mysql_num_rows($h);
//pending
$p = mysql_query("SELECT * FROM `tblmembers` WHERE `MemberApproved`='P'");
$pCount = mysql_num_rows($p);
//not sure
$n = mysql_query("SELECT * FROM `tblmembers` WHERE `MemberApproved`='N'");
$nCount = mysql_num_rows($n);
//rejected
$r = mysql_query("SELECT * FROM `tblmembers` WHERE `MemberApproved`='R'");
$rCount = mysql_num_rows($r);
/* Make the layout */
?>
<link href="cs_style.css" rel="stylesheet" type="text/css" />
<table border="1" cellpadding="3" cellspacing="1">
<tr valign="top">
<td colspan="2">Membership Status</td>
</tr>
<tr valign="top">
<td>Status</td>
<td>Total</td>
</tr>
<tr valign="top">
<td>Approved</td>
<td><a href="showMembers.php?cat=a"><?php echo $aCount;?></a></td>
</tr>
<tr valign="top">
<td>Deleted</td>
<td><a href="showMembers.php?cat=d"><?php echo $dCount;?></a></td>
</tr>
<tr valign="top">
<td>On Hold</td>
<td><a href="showMembers.php?cat=h"><?php echo $hCount;?></a></td>
</tr>
<tr valign="top">
<td>Pending</td>
<td><a href="showMembers.php?cat=p"><?php echo $pCount;?></a></td>
</tr>
<tr valign="top">
<td>Not sure</td>
<td><a href="showMembers.php?cat=n"><?php echo $nCount;?></a></td>
</tr>
<tr valign="top">
<td>Rejected</td>
<td><a href="showMembers.php?cat=r"><?php echo $rCount;?></a></td>
</tr>
<tr valign="top">
<td>Total</td>
<td><?php echo $aCount + $dCount + $hCount + $pCount + $nCount + $rCount;?></a></td>
</tr>
</table>
Your code could take long time to execute on rather larger boards, so in your queries use COUNT(*), like:
<?php
function sql_error()
{
$errstr = mysql_error();
if(!empty($errstr)
{
trigger_error($errstr, E_USER_ERROR);
}
}
function count_table($table, $wherestr = '')
{
/** Send query */
$query = @mysql_query("SELECT COUNT(*) FROM `" . $table . "`" . (($wherestr) ? ' ' . ' WHERE ' . $wherestr)) or sql_error();
/** Get count */
$count = @mysql_fetch_array($query);
$count = $count[0];
/** Free query result */
@mysql_free_result($query);
$query = null;
/** Return count */
return($count);
}
$membersR= count_table('members', '`memberApproved` = \'R\'');
?>