<?Since it's impossible to know whether the recipient has short tags enabled or not, always use the full <?php form when writing code to run on a server not one's own.
$full_string = file_get_contents($imgset);
$url_array = explode("|", $full_string);Surely it would be easier to separate the images by newlines and use file().
$num = count($url_array)-1;
if ($_GET['rand'] != "") {
$choice = $_GET['rand'];
} else {
$choice = rand(0,$num);
};
$prev = $choice-1;
$next = $choice+1;I'm sure this can be condensed... also, some lines could be blank (some editors automatically insert a blank line at the ends of files).
?>
<img alt="Random Image" src="<?php echo $url_array[$choice]; ?>" /><br />It's generally safer at the moment to assume the recipient will be using HTML.
<?php if ($choice != "0") {echo"<a href='?rand=". $prev ."'>Previos</a>";}; ?>It seems wasteful to deliberately convert a string to a number when we already know that the value to be compared is a number.
<input style="width:300px;" type="text" name="" value="http://your.domain.and/path/to/script/?rand=<?php echo $choice; ?>" />Specifying the width of an input element in pixels could cause trouble. ems would be better advised. Also, what's this textbox actually for?
<?php
function rand_img($imgset) {
$urls = file($imgset);
$len = count($urls);
$num = @$_GET['rand'];
$choice = @$urls[$num];
while(!$choice)
$choice = $urls[$num = rand(0, $len - 1)];
$prev = ($choice === 0 ? $len : $choice) - 1;
$next = ($choice + 1 === $len ? 0 : $choice) + 1;
?>
<img alt="Random Image" src="<?php echo $choice; ?>">
<a href="<?php echo $PHP_SELF . '?' . $prev; ?>">Previous</a>
<a href="<?php echo $PHP_SELF . '?' . $next; ?>">Next</a>
<?php } ?>