View Full Version : New Website
DouginBC
08-18-2006, 09:14 PM
Hi. I recently published my website (http://members.shaw.ca/allewell/) devoted to my interest in collecting vintage magazines.
The site makes use of standard HTML, style sheets, and a little javascript thrown in for good measure. Click on the website link above and have a looksee at your earliest convenience. Comments are welcome. If you don't like it, say so. I'm a big boy ... I can take constructive criticism.
Thanks. Doug
PearlDoves
08-18-2006, 09:39 PM
Hey thats really cool that you collect those... And illustrators around the world would probably love you for your interest in that, printed art gets neglected sometimes I think.. But really I would like to see you scan in the cover of some of these magazines and talk about the history and where it came from, who illustrated it and such... could prove to be interesting.... That alone could potentially open up a way for you to collect and trade for magazines that ppl have for the one you want and so on.
Sorry, I am unable to validate this document because on line 7, 9, 29 it contained one or more bytes that I cannot interpret as utf-8 (in other words, the bytes found are not valid values in the specified Character Encoding).Oh dear.
<!doctype html public "-//w3c//dtd html 3.2//en">Outdated.
<title></title>
...
<script language="Javascript">
<!-- begin
document.title="D o u g i n B C ™ • C o l l e c t i n g • V i n t a g e • M a g a z i n e s • v 1 . 1";
// end -->
</script>Huh?
<script language="Javascript">
<!-- beginlanguage is deprecated for type; hiding script like that isn't necessary.
/*
Disable Right Click Script III- by Renigade (renigade@mediaone.net)
For full source code, visit http://www.dynamicdrive.com
*/Pointless script, don't know why it's still on DD. Annoys genuine users and does nothing to stop people taking your content.
function stoperror(){
return true
}
window.onerror=stoperrorArgh. Don't hide errors from the users -- that way they'll have no idea why the button isn't doing anything. If they don't want to see errors, they'll set their browser up that way.
<meta http-equiv="imagetoolbar" content="no">Causes memory leaks, according to jscheuer1. Haven't been able to find any references though -- you'll have to ask him.
<script language="JavaScript1.2">
<!-- begin
img1=new Image()
img1.src="../images/close.jpg"
img2=new Image()
img2.src="../images/closeup.jpg"
img3=new Image()
img3.src="../images/closedwn.jpg"
// end -->
</script>Try:
<script type="text/javascript">
function preloadImages() {
if(typeof preloadImages.store === 'undefined') preloadImages.store = [];
for(var i = 0; i < arguments.length; ++i)
(preloadImages.store[preloadImages.store.length] = new Image()).src
= arguments[i];
}
preloadImages("close.jpg", "closeup.jpg", "closedwn.jpg");
</script>Avoid globals wherever possible.
<script language="JavaScript1.2">
<!-- begin
function show(id){
if (document.all) {
document.all[id].style.visibility = 'visible';
self.defaultStatus='Done';
}
}
// -->
</script>
<script language="JavaScript1.2">
<!-- begin
function hide(id){
if (document.all) {
document.all[id].style.visibility = 'hidden';
}
}
// -->
</script>Ych, IE-only.
<script type="text/javascript">
function show(id) {
var el = document.getElementById && document.getElementById(id) ?
document.getElementById(id) :
document.all && document.all[id] ?
document.all[id] :
document.images[id] || document.forms[id] || null;
if(!el) return false;
el.style.visibility = "visible";
return true;
}
function show(id) {
var el = document.getElementById && document.getElementById(id) ?
document.getElementById(id) :
document.all && document.all[id] ?
document.all[id] :
document.images[id] || document.forms[id] || null;
if(!el) return false;
el.style.visibility = "hidden";
return true;
}
</script>
<table border="0" height=100% width=100% cellspacing="0" cellpadding="0" style="position:absolute;visibility:hidden;height:100%;width:100%;background-color:transparent;cursor:default;z-index:10;">Tables shouldn't be used for layout any more. We have CSS to do the job properly now. Also, using inline CSS so much defeats the point of using CSS at all.
<script language="JavaScript">
<!-- begin
if (screen.width==800||screen.height==600)
document.write("<img src='July-15-1905.jpg' height='350' width='265' border='0' title='July 15, 1905'>")
else
document.write("<img src='July-15-1905.jpg' height='450' width='341' border='0' title='July 15, 1905'>")
// end -->
</script>Doesn't leave anything for non-JS browsers. Try:
<img id="varimg1" width="265" height="350" border="0" title="July 15, 1905">
<script type="text/javascript">
if (screen.width > 800 || screen.height > 600) {
var e;
(e = document.getElementById("varimg1").style).width = "341px";
e.height = "450px";
}
</script>
font-size:13px;Font sizes should never be specified in pixels. Use percentages instead.
font-family:verdana;Verdana is a bad choice for Web fonts, since it is larger than other fonts at the same point size. Also, you should specify a generic font family in case the user doesn't have the specific fonts you use.
<script language="JavaScript">
<!-- begin
if (screen.width==800||screen.height==600)
document.write("<span style='font-size:11;color:darkred;letter-spacing:2px;'>A collector of vintage magazines</span></br><img src='../images/dbcbanner.jpg' height='55' width='379' border='0'>")
else
document.write("<span style='font-size:13;color:darkred;letter-spacing:2px;'>A collector of vintage magazines</span></br><img src='../images/dbcbanner.jpg' height='60' width='468' border='0'>")
// end -->
</script>This wouldn't be necessary if you used proportional font sizes. Also, you need to specify units:
The fishmonger's is 3 from your house. How long, on average, will it take you to get there by bus?
if (screen.width==640||screen.height==480)
document.write("<img src='fx.jpg' height='55' width='225' border='0' vspace='3' title='F.X. Leyendecker'>")
else if (screen.width==800||screen.height==600)
document.write("<a href='javascript:show(\"fx\");' onmouseover='window.status=\"Done\";return true' onmouseout='window.status=\"Done\";return true'><img src='fx.jpg' height='55' width='225' border='0' vspace='3' title='F.X. Leyendecker'></a>")
else
document.write("<a href='javascript:show(\"fx\");' onmouseover='window.status=\"Done\";return true' onmouseout='window.status=\"Done\";return true'><img src='fx.jpg' height='55' width='225' border='0' vspace='3' title='F.X. Leyendecker'></a>")
That looks like another kludged attempt to compensate for absolute sizing. Also, the mouseover and mouseout events suggest you're trying to hide the URLs those links point to. Don't bother. It won't work.
tacmig99
08-19-2006, 12:10 AM
Wow, you should like, get paid to validate sites for people lol
What are memory leaks though?
Edit: Completely forgot to type my reply for the website.
The second page takes very long to load for some reason. My internet speed is 512kbps and for your second page is took approx. 18 seconds to load. I tried reloading to see how fast it loads using cached memory and it took approx. 5 seconds (I use FireFox's Fasterfox extension, it tells me how long the page loads for).
Also you seem to have a lot of somewhat useless stuff in your source code. The reason I say this is because the average person who views a website knows nothing about web scripting and doesn't really care about anything in your webpage except for the content he/she can actually view/read. I'd suggest only using what is actually needed and loose the extra stuff unless it's for design purposes.
In normal usage, memory is allocated, used, then freed. A memory leak is a situation that arises when someone misses out the vital last step. This causes the memory usage of the program to increase every time the code that allocates the memory is run, making the system run unresponsively and eventually crashing the program (or even the whole system, in the case of Windows; possibly still, a system crash could certainly result from a memory leak when I used WinME. Even if it can't crash the whole system nowadays, Internet Explorer handles enough to seriously confuse a novice user if it crashes: "Huh? Where's my desktop gone?").
mburt
08-19-2006, 02:14 AM
Huh? Where's my desktop gone?
I thought even novice users knew this one.. :)
Windows key + r
Then type in "explorer"
DouginBC
08-21-2006, 03:43 AM
Thanks for the (kind and not so kind) comments regarding my website. Hey, I did ask, didn't I? And no one is too old to learn something new.
I didn't agree with everything about the coding and webdesign, but I did incorporate the hide/show script into the site (once I tweaked it so it would work properly).
If nothing else I did learn a valuable lesson--if I want comments and imput about design and content, don't ask a programmer. :)
Doug
Hey, I did ask, didn't I?Exactly what I thought.
I didn't agree with everything about the coding and webdesignAll fact, I'm afraid, except the rumour about the memory leak.
If nothing else I did learn a valuable lesson--if I want comments and imput about design and content, don't ask a programmer.If you'd said you wanted comments on the design and content, I'd have focussed more on the design and content :)
I did incorporate the hide/show script into the site (once I tweaked it so it would work properly).I'm notorious for not testing code, I'm afraid :o My general approach to writing code is to sit down at a text editor and type the whole thing, then start debugging. When it's a fragment, I fear I neglect that last step all too often :)
Powered by vBulletin® Version 4.2.2 Copyright © 2021 vBulletin Solutions, Inc. All rights reserved.